Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominate developers #68

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Nominate developers #68

merged 2 commits into from
Jun 23, 2021

Conversation

dmikurube
Copy link
Member

@dmikurube dmikurube commented Jun 22, 2021

We're going to release JARs of embulk-output-elasticsearch to Maven Central from 0.5.0 (#66).

Maven Central needs the <developers> section available in pom.xml. In this chance, trying to nominate developers who have contributed a important portion in embulk-output-elasticsearch from the Git log.

@dmikurube dmikurube added this to the v0.5.0 milestone Jun 22, 2021
build.gradle Outdated
Comment on lines 128 to 131
developer {
name = "hirakiuc"
email = "hirakiuc@gmail.com"
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hirakiuc Hi!

As written in the pull-request description, we're trying to nominate developers who have contributed a important portion in embulk-output-elasticsearch.

We wonder if you're okay to nominate you in pom.xml of embulk-output-elasticsearch on Maven Central, from your work in #10. What do you think?

I picked up your name and email from the Git commit log and/or your public GitHub user page. Please let me know if you don't want to be there, or if you want to be listed in another name/email.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late response. 🙏🏽
It's OK to me. 🙆🏽‍♂️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We're also late. Going to add in #70.

Comment on lines +132 to +135
developer {
name = "Toyama Hiroshi"
email = "toyama0919@gmail.com"
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toyama0919 Hi!

As written in the pull-request description, we're trying to nominate developers who have contributed a important portion in embulk-output-elasticsearch.

We wonder if you're okay to nominate you in pom.xml of embulk-output-elasticsearch on Maven Central, from your work in #14. What do you think?

I picked up your name and email from the Git commit log and/or your public GitHub user page. Please let me know if you don't want to be there, or if you want to be listed in another name/email.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem! LGTM 👍

build.gradle Outdated
Comment on lines 140 to 143
developer {
name = "Kevin M Fitzgerald"
email = "kevin@kevinfitzgerald.net"
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kfitzgerald Hi!

As written in the pull-request description, we're trying to nominate developers who have contributed a important portion in embulk-output-elasticsearch.

We wonder if you're okay to nominate you in pom.xml of embulk-output-elasticsearch on Maven Central, from your work in #47. What do you think?

I picked up your name and email from the Git commit log and/or your public GitHub user page. Please let me know if you don't want to be there, or if you want to be listed in another name/email.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

Thanks!
-Kevin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Although we've already released v0.5.0, I'll include your name from the next version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#69

Copy link

@vietnguyen-td vietnguyen-td left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmikurube
Copy link
Member Author

Thanks! Added 4268d7a to remove nominations of those who had no responses.

I'm going to merge this PR with "Squash and merge".

Base automatically changed from apply-apache-license-2.0 to master June 23, 2021 07:35
@dmikurube dmikurube merged commit 3b26048 into master Jun 23, 2021
@dmikurube dmikurube deleted the nominate-developers branch June 23, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants