-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nominate developers #68
Conversation
build.gradle
Outdated
developer { | ||
name = "hirakiuc" | ||
email = "hirakiuc@gmail.com" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hirakiuc Hi!
As written in the pull-request description, we're trying to nominate developers who have contributed a important portion in embulk-output-elasticsearch
.
We wonder if you're okay to nominate you in pom.xml
of embulk-output-elasticsearch
on Maven Central, from your work in #10. What do you think?
I picked up your name and email from the Git commit log and/or your public GitHub user page. Please let me know if you don't want to be there, or if you want to be listed in another name/email.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my late response. 🙏🏽
It's OK to me. 🙆🏽♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We're also late. Going to add in #70.
developer { | ||
name = "Toyama Hiroshi" | ||
email = "toyama0919@gmail.com" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toyama0919 Hi!
As written in the pull-request description, we're trying to nominate developers who have contributed a important portion in embulk-output-elasticsearch
.
We wonder if you're okay to nominate you in pom.xml
of embulk-output-elasticsearch
on Maven Central, from your work in #14. What do you think?
I picked up your name and email from the Git commit log and/or your public GitHub user page. Please let me know if you don't want to be there, or if you want to be listed in another name/email.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem! LGTM 👍
build.gradle
Outdated
developer { | ||
name = "Kevin M Fitzgerald" | ||
email = "kevin@kevinfitzgerald.net" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kfitzgerald Hi!
As written in the pull-request description, we're trying to nominate developers who have contributed a important portion in embulk-output-elasticsearch
.
We wonder if you're okay to nominate you in pom.xml
of embulk-output-elasticsearch
on Maven Central, from your work in #47. What do you think?
I picked up your name and email from the Git commit log and/or your public GitHub user page. Please let me know if you don't want to be there, or if you want to be listed in another name/email.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me!
Thanks!
-Kevin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Although we've already released v0.5.0, I'll include your name from the next version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! Added 4268d7a to remove nominations of those who had no responses. I'm going to merge this PR with "Squash and merge". |
We're going to release JARs of
embulk-output-elasticsearch
to Maven Central from 0.5.0 (#66).Maven Central needs the
<developers>
section available inpom.xml
. In this chance, trying to nominate developers who have contributed a important portion inembulk-output-elasticsearch
from the Git log.