fix handling null value #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for investigating. I didn't notice that issue. I will merge your code and release new version. |
|
released embulk-output-elasticsearch v0.1.7. thank you very much @hirakiuc ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: issue #9
I've investigated what is difference of this plugin and embulk-output-jdbc plugin.
Finally, I found the difference, this plugin is not check whether column value is null or not null.
So this pull request add
handling null valuefeature like ColumnSetter of embulk-output-jdbc plugin.note
I tested this code with large log file (191705 lines) and loaded to my elasticsearch successfully.