fix snippet resolving

[ef4]

#593 broke some cases when you're parsing component snippts in packageRules at an early point in the build when the app itself doesn't have a package.json yet. This fixes the problem by ensuring we don't try to discover the owningPackage for our own stuff when we know it's owned by the app.

[simonihmig]

This seems to also fix a real issue in an app, not only related to snippets in package rules. Wehen updating an app to 0.30.0 from 0.28.0, the build started to fail with The "path" argument must be of type string. Received undefined, due to packageRuntimeName being undefined. pkg was an object, with dependencies, fastboot and embroider-fastboot being the only keys there, but no name. Patching my node_modules with the changes here fixed the issue.

absPath was referring to https://github.com/tildeio/ember-element-helper/blob/main/app/components/-dynamic-element.js, don't know if there was something specific to that or not, as I didn't investigate this further. Just fyi!

[ef4]

Yup, that's the same bug. We have a built-in rule that has a snippet for that component:

embroider/packages/compat/src/addon-dependency-rules/ember-element-helper.ts

Line 7 in 4a58720

dependsOnComponents: ['{{-dynamic-element}}', '{{-dynamic-element-alt}}'],

[simonihmig]

We have a built-in rule that has a snippet for that component:

Yup, I added that! :)

However I was not sure how this plays together. But thanks for confirming!