support component helper invocation with an @ in the name #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the one place where templates can reach directly out into other package's namespaces. It means that the CompatResolver needs to know a lot more about the prevailing renaming rules.
ef4
added a commit
that referenced
this pull request
Nov 5, 2020
#593 broke some cases when you're parsing component snippts in packageRules at an early point in the build when the app itself doesn't have a package.json yet. This fixes the problem by ensuring we don't try to discover the owningPackage for our own stuff when we know it's owned by the app.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.