fix: use join vs run for deleteRecord destroy of new records #8307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8262
I'm not entirely convinced this is safe, though it passes tests. We're close to disentangling from the runloop entirely, should probably try to finish that off so we can be certain.
The rough cause of the issue is that Ember apparently now flushes render after every
run
, so nested runs are no longer safe. Unsure when this changed.