deps(ember): upgrade to latest LTS (4.8.x) #1011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Closes #1005
Part of https://github.com/meroxa/product/issues/749
With this change, we're upgrading
conduit/ui
fromember@4.0.1
to the latest LTSember@4.8.x
. This way,conduit/ui
can also upgrade to latest security patches provided to Ember until December 2023.This upgrade includes several minor version bumps in order to benefit from a bug fix in @ember/data that just landed in the 4.9 release. The related bug prevented us from upgrading beyond
ember@4.7
due to an error in identifying new data records wrapped with ember-changeset correctly (Assertion Failed: Expected to receive a stable Identifier to subscribe to
).In addition, this upgrade includes:
Resolutions
The following changes were made to upgrade:
ember-cli-update --to 4.8
rm -rf node_modules && yarn
to remove the existing npm packages and start a fresh installember t -s
to start the test suite and see errors related to the upgradesudo yarn start
to verify the changes locally athttps://dev.meroxa.io
Build error
@babel/template placeholder "SAMPLE_FEATURE_FLAG": Expected string substitution
@embroider/macros
error in your terminal window (Build failure)--> you should see the error stack trace pointing to the
node_modules
and you should see a reference toember-cli-mirage
package.json
:rm -rf node_modules && yarn
to remove the existing npm packages and start a fresh installBlockers before merging
How to verify?
Quick checks: