[CHORE] 11! #6819

runspired · 2019-11-27T19:48:45Z

We've been compressing at max because the default brotli setting is 11, but this makes it explicit just in case that default is ever different.

It also tidies up a bit how we do our compression math, which makes it easier to improve our diff.

We improve our diff by adjusting the formula for how we calculate the delta in compression.

Before, the delta for individual modules and packages was calculated like this:

LibraryDelta = NewLibraryCompressedSize - OldLibraryCompressedSize;
CompressedSizeInitial = OldSize / OldLibrarySize * OldLibraryCompressedSize;
CompressedSizeFinal = NewSize / NewLibrarySize * NewLibraryCompressedSize;
CompressionDelta = CompressedSizeFinal - CompressedSizeInitial;

While on the surface this equation seems to make sense, because compression is not directly related to the relative size of a package it results in module/package compression deltas that do not sum to the overall compression delta of the library. Because the module or package changes its "% of the library", the two sizes are not directly comparable leading to an exaggerated compression delta that is less meaningful.

In this PR we shift to a strategy that is comparable and will sum to the overall library compression delta.

LibraryCompressionDelta = NewLibCompressedSize - OldLibCompressedSize;
LibraryDelta = NewLibSize - OldLibSize
ItemDelta = NewItemSize - OldItemSize;
RelativeDelta = ItemDelta / LibraryDelta;
CompressionDelta = RelativeDelta * LibraryCompressionDelta;

From a Math perspective we've made the following change in our formula;

Given the following:

M1 = item's initial size
M2 = item's final size
L1 = library's initial size
L2 = library's final size
LC1 = library's initial compressed size
LC2 = library's final compressed size
ΔMC = the change in the item's compression size

Our initial formula was:

ΔMC = (M2/L2*LC2) - (M1/L1*LC1)

And our new formula is:

ΔMC = (M2-M1) / (L2-L1) * (LC2-LC1)

These equations are not equivalent.

Example Analysis of an asset size change prior to this formula update: #6814 (comment)

Example Analysis of an asset size change after this formula update:
#6814 (comment)

github-actions · 2019-11-27T21:05:32Z

Asset Size Report for 39938ec

EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset

Full Asset Analysis


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '160.31 KB' │
│ compressed │ '34.23 KB'  │
│  packages  │      9      │
│  modules   │     47      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '71.04 KB' │
│  compressed  │ '15.17 KB' │
│ % Of Library │   '44.3'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                    | 70.13 KB  | 14.97 KB   | 98.7          | 43.7
	@ember-data/store/index                       | 936.00 B  | 199.86 B   | 1.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.97 KB' │
│  compressed  │ '4.91 KB'  │
│ % Of Library │   '14.3'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private              | 22.97 KB  | 4.91 KB    | 100.0         | 14.3

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.30 KB' │
│  compressed  │ '4.12 KB'  │
│ % Of Library │   '12.0'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                   | 7.10 KB   | 1.52 KB    | 36.8          | 4.4
	@ember-data/serializer/-private               | 5.36 KB   | 1.14 KB    | 27.8          | 3.3
	@ember-data/serializer/json-api               | 3.71 KB   | 810.54 B   | 19.2          | 2.3
	@ember-data/serializer/rest                   | 2.68 KB   | 585.70 B   | 13.9          | 1.7
	@ember-data/serializer/index                  | 243.00 B  | 51.88 B    | 1.2           | 0.1
	@ember-data/serializer/transform              | 215.00 B  | 45.90 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.57 KB' │
│  compressed  │ '3.11 KB'  │
│ % Of Library │   '9.1'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                      | 7.65 KB   | 1.63 KB    | 52.5          | 4.8
	@ember-data/adapter/-private                  | 3.50 KB   | 765.28 B   | 24.0          | 2.2
	@ember-data/adapter/error                     | 1.91 KB   | 418.29 B   | 13.1          | 1.2
	@ember-data/adapter/json-api                  | 830.00 B  | 177.22 B   | 5.6           | 0.5
	@ember-data/adapter/index                     | 719.00 B  | 153.52 B   | 4.8           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '11.08 KB' │
│  compressed  │ '2.36 KB'  │
│ % Of Library │   '6.9'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                    | 10.60 KB  | 2.26 KB    | 95.7          | 6.6
	@ember-data/model/index                       | 486.00 B  | 103.77 B   | 4.3           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.72 KB' │
│  compressed  │ '2.08 KB' │
│ % Of Library │   '6.1'   │
└──────────────┴───────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                              | 2.42 KB   | 529.33 B   | 24.9          | 1.5
	ember-data/-private                           | 1.98 KB   | 433.24 B   | 20.4          | 1.2
	ember-data/adapters/errors                    | 1.19 KB   | 259.86 B   | 12.2          | 0.7
	ember-data/setup-container                    | 503.00 B  | 107.40 B   | 5.1           | 0.3
	ember-data/store                              | 406.00 B  | 86.69 B    | 4.1           | 0.2
	ember-data/relationships                      | 318.00 B  | 67.90 B    | 3.2           | 0.2
	ember-data/serializers/embedded-records-mixin | 274.00 B  | 58.50 B    | 2.8           | 0.2
	ember-data/serializers/json-api               | 251.00 B  | 53.59 B    | 2.5           | 0.2
	ember-data/adapters/json-api                  | 245.00 B  | 52.31 B    | 2.5           | 0.1
	ember-data/serializers/json                   | 243.00 B  | 51.88 B    | 2.4           | 0.1
	ember-data/serializers/rest                   | 243.00 B  | 51.88 B    | 2.4           | 0.1
	ember-data/transform                          | 241.00 B  | 51.45 B    | 2.4           | 0.1
	ember-data/adapters/rest                      | 237.00 B  | 50.60 B    | 2.4           | 0.1
	ember-data/serializer                         | 232.00 B  | 49.53 B    | 2.3           | 0.1
	ember-data/adapter                            | 226.00 B  | 48.25 B    | 2.3           | 0.1
	ember-data/model                              | 222.00 B  | 47.40 B    | 2.2           | 0.1
	ember-data/attr                               | 218.00 B  | 46.54 B    | 2.2           | 0.1
	ember-data/initialize-store-service           | 207.00 B  | 44.20 B    | 2.1           | 0.1
	ember-data/version                            | 162.00 B  | 34.59 B    | 1.6           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.90 KB' │
│  compressed  │ '1.69 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector          | 2.75 KB   | 601.50 B   | 34.8          | 1.7
	ember-inflector/lib/system/inflections        | 1.57 KB   | 343.77 B   | 19.9          | 1.0
	ember-inflector/index                         | 1.12 KB   | 245.12 B   | 14.2          | 0.7
	ember-inflector/lib/ext/string                | 783.00 B  | 167.19 B   | 9.7           | 0.5
	ember-inflector/lib/system                    | 452.00 B  | 96.51 B    | 5.6           | 0.3
	ember-inflector/lib/system/string             | 351.00 B  | 74.94 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize         | 348.00 B  | 74.30 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper         | 308.00 B  | 65.76 B    | 3.8           | 0.2
	ember-inflector/lib/helpers/singularize       | 271.00 B  | 57.86 B    | 3.4           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.68 KB'  │
│  compressed  │ '585.70 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                       | 2.19 KB   | 479.15 B   | 81.8          | 1.4
	@ember-data/debug/setup                       | 499.00 B  | 106.54 B   | 18.2          | 0.3

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.05 KB'  │
│  compressed  │ '230.18 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                      | 1.05 KB   | 230.18 B   | 100.0         | 0.7

Gaurav0

Math LGTM. I'm only commenting on naming things.

bin/asset-size-tracking/generate-diff.js

bin/asset-size-tracking/src/library.js

github-actions · 2019-11-30T02:40:06Z

Performance Report for 39938ec

Relationship Analysis

                        -------------

__/\\\\\\\\\\\\\____/\\\\____________/\\\\____/\\\\\\\\\_____
 _\/\\\/////////\\\_\/\\\\\\________/\\\\\\__/\\\///////\\\___
  _\/\\\_______\/\\\_\/\\\//\\\____/\\\//\\\_\///______\//\\\__
   _\/\\\\\\\\\\\\\/__\/\\\\///\\\/\\\/_\/\\\___________/\\\/___
    _\/\\\/////////____\/\\\__\///\\\/___\/\\\________/\\\//_____
     _\/\\\_____________\/\\\____\///_____\/\\\_____/\\\//________
      _\/\\\_____________\/\\\_____________\/\\\___/\\\/___________
       _\/\\\_____________\/\\\_____________\/\\\__/\\\\\\\\\\\\\\\_
        _\///______________\///______________\///__\///////////////__


                          Runtime Edition

        PM2 is a Production Process Manager for Node.js applications
                     with a built-in Load Balancer.

                Start and Daemonize any application:
                $ pm2 start app.js

                Load Balance 4 instances of api.js:
                $ pm2 start api.js -i 4

                Monitor in production:
                $ pm2 monitor

                Make pm2 auto-boot at server restart:
                $ pm2 startup

                To go further checkout:
                http://pm2.io/


                        -------------

[PM2] Spawning PM2 daemon with pm2_home=/home/runner/.pm2
[PM2] PM2 Successfully daemonized
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬──────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name     │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼──────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control  │ default     │ N/A     │ fork    │ 2991     │ 0s     │ 0    │ online    │ 0%       │ 35.2mb   │ runner   │ disabled │
└─────┴──────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬─────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name        │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼─────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control     │ default     │ N/A     │ fork    │ 2991     │ 0s     │ 0    │ online    │ 0%       │ 69.3mb   │ runner   │ disabled │
│ 1   │ experiment  │ default     │ N/A     │ fork    │ 3016     │ 0s     │ 0    │ online    │ 0%       │ 32.2mb   │ runner   │ disabled │
└─────┴─────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
Computing results...


┌───────────────────────────────────────────────────────────────────────┐
│ Initial Render : duration                                             │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1864ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 2194ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1900ms                 │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 1921ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1949ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1990ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 2019ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1861ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 2133ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1890ms                 │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 1919ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1951ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1982ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 2026ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 3ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ -17ms to 19ms                │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▂█▆▃▁▁▁                      │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▄█▇▃▁▁▁                      │
└────────────────────────────────────────┴──────────────────────────────┘


┌───────────────────────────────────────────────────────────────────────┐
│ Sub Phase of Duration : start-find-all                                │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1314ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 1544ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1335ms                 │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 1361ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1378ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1411ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1442ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1310ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 1527ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1347ms                 │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 1363ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1388ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1417ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1435ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 3ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ -12ms to 17ms                │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▂▂▄█▄▄▃▂▁▁▁▁▁                │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁▃▆▆█▄▆▂▁▁▁▁▁                │
├────────────────────────────────────────┴──────────────────────────────┤
│ Sub Phase of Duration : start-outer-materialization                   │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 497ms                   │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 640ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 516ms                  │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 522ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 534ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 554ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 617ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 505ms                   │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 676ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 512ms                  │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 524ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 533ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 548ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 594ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ -1ms                         │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ -9ms to 7ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁▅█▆▁▁▂▂▁▁                   │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁▃█▄▂▁▁▁▁▁                   │
├────────────────────────────────────────┴──────────────────────────────┤
│ Sub Phase of Duration : stop-outer-materialization                    │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 0ms                    │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 0ms                    │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 0ms                    │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 0ms                    │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 0ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ 0ms to 0ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ █▃▁▁▁▁▁▁▁                    │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ █▂▂▁▁▁▁▁▁                    │
├────────────────────────────────────────┴──────────────────────────────┤
│ Sub Phase of Duration : end-find-all                                  │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 22ms                    │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 45ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 22ms                   │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 23ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 24ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 25ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 30ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 21ms                    │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 42ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 22ms                   │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 23ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 23ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 25ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 36ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 0ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ -1ms to 0ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁█▄▂▁▁▁▁▁▁▁▁▁                │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁█▂▁▁▁▁▁▁▁▁▁▁                │
└────────────────────────────────────────┴──────────────────────────────┘

    =========== Benchmark Results Summary ===========    
Red color means there was a regression. Green color means there was an improvement. You can view more statistical details about the phases above.

duration phase has no difference. 

start-find-all phase has no difference. 

start-outer-materialization phase has no difference. 

stop-outer-materialization phase has no difference. 

end-find-all phase has an estimated difference of -0ms. 

[PM2] [v] Modules Stopped
[PM2] Applying action deleteProcessId on app [all](ids: [ 0, 1 ])
[PM2] [control](0) ✓
[PM2] [experiment](1) ✓
[PM2] [v] All Applications Stopped
[PM2] [v] PM2 Daemon Stopped

igorT · 2019-12-01T17:40:38Z

Fwiw a commit message that mentions that this is related to asset size diffing/etc. would've been great. It's pretty hard to tell what 11! refers to when going through a list of commits

runspired force-pushed the chore/take-it-to-11 branch from 4c650b8 to 98f7ead Compare November 27, 2019 20:15

runspired changed the title ~~11?~~ [CHORE] 11! Nov 27, 2019

runspired requested a review from rwjblue November 27, 2019 20:21

runspired force-pushed the chore/take-it-to-11 branch from f04a1e7 to 0fe1503 Compare November 27, 2019 21:03

emberjs deleted a comment from github-actions bot Nov 27, 2019

runspired added 🏷️ chore This PR primarily refactors code or updates dependencies CI labels Nov 27, 2019

runspired requested a review from igorT November 28, 2019 00:05

runspired assigned igorT Nov 28, 2019

Gaurav0 reviewed Nov 30, 2019

View reviewed changes

bin/asset-size-tracking/generate-diff.js Outdated Show resolved Hide resolved

bin/asset-size-tracking/src/library.js Outdated Show resolved Hide resolved

runspired added 3 commits November 29, 2019 18:32

11

f1eaa0e

compression deltas

65af610

cleanup

bd3e4d1

runspired force-pushed the chore/take-it-to-11 branch from cac3a9b to bd3e4d1 Compare November 30, 2019 02:32

it helps to return the 11

39938ec

runspired merged commit e54d12b into master Nov 30, 2019

delete-merged-branch bot deleted the chore/take-it-to-11 branch November 30, 2019 03:11

runspired added Infra/CI/DX and removed CI labels Sep 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CHORE] 11! #6819

[CHORE] 11! #6819

runspired commented Nov 27, 2019 •

edited

Loading

github-actions bot commented Nov 27, 2019 •

edited

Loading

Gaurav0 left a comment

github-actions bot commented Nov 30, 2019 •

edited

Loading

igorT commented Dec 1, 2019

[CHORE] 11! #6819

[CHORE] 11! #6819

Conversation

runspired commented Nov 27, 2019 • edited Loading

github-actions bot commented Nov 27, 2019 • edited Loading

Gaurav0 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 30, 2019 • edited Loading

igorT commented Dec 1, 2019

runspired commented Nov 27, 2019 •

edited

Loading

github-actions bot commented Nov 27, 2019 •

edited

Loading

github-actions bot commented Nov 30, 2019 •

edited

Loading