[FEAT] Strip resolved Deprecations #6814

runspired · 2019-11-27T08:26:35Z

Allows build-time stripping of resolved deprecations from production builds.

With this change, users may configure EmberData to remove support for deprecated behaviors by supplying the minimum version of EmberData with which they are fully compatible.

For instance, if a deprecation was introduced in 3.13, and the app specifies 3.13 as its minimum version compatibility, any deprecations introduced before or during 3.13 would be stripped away.

This configuration is done by an app's ember-cli-build file and looks like this:

let app = new EmberApp(defaults, {
    emberData: {
      compatWith: '3.12',
    },
});

Instead of tracking down the precise versions in which all of our existing deprecations were added, wherever I was unsure they have been conservatively set to at least 2 minor versions after they were introduced, and in some cases many more.

export default {
  DEPRECATE_EVENTED_API_USAGE: '3.12',
  DEPRECATE_RECORD_LIFECYCLE_EVENT_METHODS: '3.12',
  DEPRECATE_MODEL_DATA: '3.8',
  DEPRECATE_MODEL_TOJSON: '3.15',
  DEPRECATE_LEGACY_TEST_HELPER_SUPPORT: '3.15',
  DEPRECATE_LEGACY_TEST_REGISTRATIONS: '3.15',
  DEPRECATE_DEFAULT_SERIALIZER: '3.15',
  DEPRECATE_DEFAULT_ADAPTER: '3.15',
  DEPRECATE_METHOD_CALLS_ON_DESTROY_STORE: '3.15',
  DEPRECATE_MISMATCHED_INVERSE_RELATIONSHIP_DATA: '3.12',
  DEPRECATE_SERIALIZER_QUERY_RECORD_ARRAY_RESPONSE: '3.4',
};

This PR additionally adds a github-actions test scenario in which we run our tests with all deprecations stripped.
Deprecation flags are named imports from @ember-data/private-build-infra/deprecations, e.g.

import { DEPRECATE_EVENTED_API_USAGE } from '@ember-data/private-build-infra/deprecations';

Deprecation flag names follow the pattern of DEPRECATE_{deprecation-id-in-caps}

github-actions · 2019-11-27T21:14:31Z

Asset Size Report for 33ba6d5

IE11 Builds

EmberData shrank by 955.0 B (167.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData 176.54 KB -955.0 B (35.72 KB -167.0 B compressed)
    @ember-data/store 77.47 KB -492.0 B (15.67 KB -86.04 B compressed)
        @ember-data/store/-private 76.56 KB -492.0 B (15.49 KB -86.04 B compressed)
    @ember-data/model 14.35 KB -463.0 B (2.9 KB -80.96 B compressed)
        @ember-data/model/-private 13.88 KB -463.0 B (2.81 KB -80.96 B compressed)

Full Asset Analysis (IE11)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '176.54 KB' │
│ compressed │ '35.72 KB'  │
│  packages  │      9      │
│  modules   │     47      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '77.47 KB' │
│  compressed  │ '15.67 KB' │
│ % Of Library │   '43.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 76.56 KB  | 15.49 KB   | 98.8          | 43.4
	@ember-data/store/index                           | 936.00 B  | 189.36 B   | 1.2           | 0.5

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '25.96 KB' │
│  compressed  │ '5.25 KB'  │
│ % Of Library │   '14.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 25.96 KB  | 5.25 KB    | 100.0         | 14.7

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.83 KB' │
│  compressed  │ '4.21 KB'  │
│ % Of Library │   '11.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.75 KB   | 1.57 KB    | 37.2          | 4.4
	@ember-data/serializer/-private                   | 5.68 KB   | 1.15 KB    | 27.3          | 3.2
	@ember-data/serializer/json-api                   | 3.95 KB   | 817.55 B   | 18.9          | 2.2
	@ember-data/serializer/rest                       | 2.99 KB   | 620.09 B   | 14.4          | 1.7
	@ember-data/serializer/index                      | 258.00 B  | 52.19 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 43.49 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.31 KB' │
│  compressed  │ '3.10 KB'  │
│ % Of Library │   '8.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.05 KB   | 1.63 KB    | 52.6          | 4.6
	@ember-data/adapter/-private                      | 3.67 KB   | 759.89 B   | 24.0          | 2.1
	@ember-data/adapter/error                         | 1.95 KB   | 403.41 B   | 12.7          | 1.1
	@ember-data/adapter/json-api                      | 882.00 B  | 178.44 B   | 5.6           | 0.5
	@ember-data/adapter/index                         | 804.00 B  | 162.66 B   | 5.1           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.35 KB' │
│  compressed  │ '2.90 KB'  │
│ % Of Library │   '8.1'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 13.88 KB  | 2.81 KB    | 96.7          | 7.9
	@ember-data/model/index                           | 486.00 B  | 98.32 B    | 3.3           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.89 KB' │
│  compressed  │ '2.00 KB' │
│ % Of Library │   '5.6'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 501.53 B   | 24.5          | 1.4
	ember-data/-private                               | 1.98 KB   | 410.49 B   | 20.0          | 1.1
	ember-data/adapters/errors                        | 1.19 KB   | 246.21 B   | 12.0          | 0.7
	ember-data/store                                  | 585.00 B  | 118.35 B   | 5.8           | 0.3
	ember-data/setup-container                        | 503.00 B  | 101.76 B   | 5.0           | 0.3
	ember-data/relationships                          | 318.00 B  | 64.33 B    | 3.1           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 55.43 B    | 2.7           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 50.78 B    | 2.5           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 49.56 B    | 2.4           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 49.16 B    | 2.4           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 49.16 B    | 2.4           | 0.1
	ember-data/transform                              | 241.00 B  | 48.75 B    | 2.4           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 47.94 B    | 2.3           | 0.1
	ember-data/serializer                             | 232.00 B  | 46.93 B    | 2.3           | 0.1
	ember-data/adapter                                | 226.00 B  | 45.72 B    | 2.2           | 0.1
	ember-data/model                                  | 222.00 B  | 44.91 B    | 2.2           | 0.1
	ember-data/attr                                   | 218.00 B  | 44.10 B    | 2.2           | 0.1
	ember-data/initialize-store-service               | 207.00 B  | 41.87 B    | 2.0           | 0.1
	ember-data/version                                | 162.00 B  | 32.77 B    | 1.6           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.41 KB' │
│  compressed  │ '1.70 KB' │
│ % Of Library │   '4.8'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.02 KB   | 624.74 B   | 35.9          | 1.7
	ember-inflector/lib/system/inflections            | 1.57 KB   | 325.72 B   | 18.7          | 0.9
	ember-inflector/index                             | 1.16 KB   | 240.14 B   | 13.8          | 0.7
	ember-inflector/lib/ext/string                    | 809.00 B  | 163.67 B   | 9.4           | 0.4
	ember-inflector/lib/helpers/pluralize             | 523.00 B  | 105.81 B   | 6.1           | 0.3
	ember-inflector/lib/system                        | 452.00 B  | 91.44 B    | 5.2           | 0.3
	ember-inflector/lib/system/string                 | 365.00 B  | 73.84 B    | 4.2           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 62.31 B    | 3.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 271.00 B  | 54.82 B    | 3.1           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.96 KB'  │
│  compressed  │ '612.60 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.47 KB   | 511.44 B   | 83.5          | 1.4
	@ember-data/debug/setup                           | 500.00 B  | 101.15 B   | 16.5          | 0.3

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.35 KB'  │
│  compressed  │ '278.78 B' │
│ % Of Library │   '0.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                          | 1.35 KB   | 278.77 B   | 100.0         | 0.8

Modern Builds

EmberData shrank by 912.0 B (178.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData 159.87 KB -912.0 B (34.15 KB -178.0 B compressed)
    @ember-data/store 68.39 KB -492.0 B (14.61 KB -96.03 B compressed)
        @ember-data/store/-private 67.47 KB -492.0 B (14.41 KB -96.03 B compressed)
    @ember-data/model 13.24 KB -420.0 B (2.83 KB -81.97 B compressed)
        @ember-data/model/-private 12.77 KB -420.0 B (2.73 KB -81.97 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '159.87 KB' │
│ compressed │ '34.15 KB'  │
│  packages  │      9      │
│  modules   │     47      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '68.39 KB' │
│  compressed  │ '14.61 KB' │
│ % Of Library │   '42.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 67.47 KB  | 14.41 KB   | 98.7          | 42.2
	@ember-data/store/index                           | 936.00 B  | 199.95 B   | 1.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.97 KB' │
│  compressed  │ '4.91 KB'  │
│ % Of Library │   '14.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 22.97 KB  | 4.91 KB    | 100.0         | 14.4

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.32 KB' │
│  compressed  │ '4.13 KB'  │
│ % Of Library │   '12.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.10 KB   | 1.52 KB    | 36.8          | 4.4
	@ember-data/serializer/-private                   | 5.36 KB   | 1.15 KB    | 27.7          | 3.4
	@ember-data/serializer/json-api                   | 3.71 KB   | 810.91 B   | 19.2          | 2.3
	@ember-data/serializer/rest                       | 2.70 KB   | 591.09 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 243.00 B  | 51.91 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 45.92 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.60 KB' │
│  compressed  │ '3.12 KB'  │
│ % Of Library │   '9.1'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.67 KB   | 1.64 KB    | 52.5          | 4.8
	@ember-data/adapter/-private                      | 3.50 KB   | 765.62 B   | 24.0          | 2.2
	@ember-data/adapter/error                         | 1.91 KB   | 418.48 B   | 13.1          | 1.2
	@ember-data/adapter/json-api                      | 830.00 B  | 177.30 B   | 5.6           | 0.5
	@ember-data/adapter/index                         | 719.00 B  | 153.59 B   | 4.8           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '13.24 KB' │
│  compressed  │ '2.83 KB'  │
│ % Of Library │   '8.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 12.77 KB  | 2.73 KB    | 96.4          | 8.0
	@ember-data/model/index                           | 486.00 B  | 103.82 B   | 3.6           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.72 KB' │
│  compressed  │ '2.08 KB' │
│ % Of Library │   '6.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 529.57 B   | 24.9          | 1.5
	ember-data/-private                               | 1.98 KB   | 433.44 B   | 20.4          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 259.97 B   | 12.2          | 0.7
	ember-data/setup-container                        | 503.00 B  | 107.45 B   | 5.1           | 0.3
	ember-data/store                                  | 406.00 B  | 86.73 B    | 4.1           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.93 B    | 3.2           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.53 B    | 2.8           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 53.61 B    | 2.5           | 0.2
	ember-data/adapters/json-api                      | 245.00 B  | 52.33 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.91 B    | 2.4           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.91 B    | 2.4           | 0.1
	ember-data/transform                              | 241.00 B  | 51.48 B    | 2.4           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.62 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.56 B    | 2.3           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.27 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 47.42 B    | 2.2           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.56 B    | 2.2           | 0.1
	ember-data/initialize-store-service               | 207.00 B  | 44.21 B    | 2.1           | 0.1
	ember-data/version                                | 162.00 B  | 34.60 B    | 1.6           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.90 KB' │
│  compressed  │ '1.69 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.75 KB   | 601.77 B   | 34.8          | 1.7
	ember-inflector/lib/system/inflections            | 1.57 KB   | 343.93 B   | 19.9          | 1.0
	ember-inflector/index                             | 1.12 KB   | 245.23 B   | 14.2          | 0.7
	ember-inflector/lib/ext/string                    | 783.00 B  | 167.26 B   | 9.7           | 0.5
	ember-inflector/lib/system                        | 452.00 B  | 96.55 B    | 5.6           | 0.3
	ember-inflector/lib/system/string                 | 351.00 B  | 74.98 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize             | 348.00 B  | 74.34 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 65.79 B    | 3.8           | 0.2
	ember-inflector/lib/helpers/singularize           | 271.00 B  | 57.89 B    | 3.4           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.68 KB'  │
│  compressed  │ '585.96 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.19 KB   | 479.36 B   | 81.8          | 1.4
	@ember-data/debug/setup                           | 499.00 B  | 106.59 B   | 18.2          | 0.3

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.05 KB'  │
│  compressed  │ '230.28 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                          | 1.05 KB   | 230.28 B   | 100.0         | 0.7

Modern Builds (No Rollup)

EmberData shrank by 910.0 B (175.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData 202.94 KB -910.0 B (38.41 KB -175.0 B compressed)
    @ember-data/store 99.56 KB -491.0 B (18.84 KB -94.42 B compressed)
        @ember-data/store/-private/system/core-store 17.06 KB -418.0 B (3.23 KB -80.38 B compressed)
        @ember-data/store/-private/system/record-arrays/adapter-populated-record-array 856.0 B -62.0 B (162.02 B -11.92 B compressed)
        @ember-data/store/-private/system/deprecated-evented 190.0 B -11.0 B (35.96 B -2.12 B compressed)
    @ember-data/model 17.2 KB -419.0 B (3.26 KB -80.58 B compressed)
        @ember-data/model/-private/model 6.28 KB -419.0 B (1.19 KB -80.58 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '202.94 KB' │
│ compressed │ '38.41 KB'  │
│  packages  │      9      │
│  modules   │     143     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '99.56 KB' │
│  compressed  │ '18.84 KB' │
│ % Of Library │   '49.1'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.06 KB  | 3.23 KB    | 17.1          | 8.4
	@ember-data/store/-private/system/model/internal-model                             | 16.99 KB  | 3.22 KB    | 17.1          | 8.4
	@ember-data/store/-private/system/model/states                                     | 5.44 KB   | 1.03 KB    | 5.5           | 2.7
	@ember-data/store/-private/system/fetch-manager                                    | 4.91 KB   | 951.30 B   | 4.9           | 2.4
	@ember-data/store/-private/system/store/finders                                    | 4.31 KB   | 836.22 B   | 4.3           | 2.1
	@ember-data/store/-private/index                                                   | 4.23 KB   | 819.18 B   | 4.2           | 2.1
	@ember-data/store/-private/system/record-array-manager                             | 3.58 KB   | 694.83 B   | 3.6           | 1.8
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.43 KB   | 664.54 B   | 3.4           | 1.7
	@ember-data/store/-private/identifiers/cache                                       | 3.36 KB   | 651.86 B   | 3.4           | 1.7
	@ember-data/store/-private/system/snapshot                                         | 3.00 KB   | 580.88 B   | 3.0           | 1.5
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.82 KB   | 546.62 B   | 2.8           | 1.4
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.03 KB   | 394.26 B   | 2.0           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.99 KB   | 385.17 B   | 2.0           | 1.0
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 367.00 B   | 1.9           | 0.9
	@ember-data/store/-private/system/relationship-meta                                | 1.47 KB   | 285.04 B   | 1.5           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.47 KB   | 284.86 B   | 1.5           | 0.7
	@ember-data/store/-private/system/references/has-many                              | 1.38 KB   | 266.87 B   | 1.4           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.26 KB   | 244.16 B   | 1.3           | 0.6
	@ember-data/store/-private/system/references/belongs-to                            | 1.18 KB   | 228.07 B   | 1.2           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.12 KB   | 217.85 B   | 1.1           | 0.6
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 204.03 B   | 1.1           | 0.5
	@ember-data/store/index                                                            | 936.00 B  | 177.16 B   | 0.9           | 0.5
	@ember-data/store/-private/system/internal-model-map                               | 916.00 B  | 173.37 B   | 0.9           | 0.4
	@ember-data/store/-private/system/model/notify-changes                             | 862.00 B  | 163.15 B   | 0.8           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 856.00 B  | 162.02 B   | 0.8           | 0.4
	@ember-data/store/-private/system/references/record                                | 783.00 B  | 148.20 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 768.00 B  | 145.36 B   | 0.8           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 758.00 B  | 143.47 B   | 0.7           | 0.4
	@ember-data/store/-private/system/record-notification-manager                      | 689.00 B  | 130.41 B   | 0.7           | 0.3
	@ember-data/store/-private/system/references/reference                             | 686.00 B  | 129.84 B   | 0.7           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 113.18 B   | 0.6           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 556.00 B  | 105.23 B   | 0.5           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 506.00 B  | 95.77 B    | 0.5           | 0.2
	@ember-data/store/-private/system/store/common                                     | 499.00 B  | 94.44 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 92.17 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 85.17 B    | 0.4           | 0.2
	@ember-data/store/-private/system/diff-array                                       | 438.00 B  | 82.90 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 414.00 B  | 78.36 B    | 0.4           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 407.00 B  | 77.03 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/utils/symbol                              | 406.00 B  | 76.84 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 61.89 B    | 0.3           | 0.2
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 59.81 B    | 0.3           | 0.2
	@ember-data/store/-private/utils/promise-record                                    | 288.00 B  | 54.51 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/utils/brand                               | 286.00 B  | 54.13 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 268.00 B  | 50.72 B    | 0.3           | 0.1
	@ember-data/store/-private/system/ts-upgrade-map                                   | 248.00 B  | 46.94 B    | 0.2           | 0.1
	@ember-data/store/-private/system/record-data-for                                  | 235.00 B  | 44.47 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.12 B    | 0.2           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 210.00 B  | 39.74 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 193.00 B  | 36.53 B    | 0.2           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 190.00 B  | 35.96 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 150.00 B  | 28.39 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 144.00 B  | 27.25 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 98.00 B   | 18.54 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 96.00 B   | 18.17 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 95.00 B   | 17.98 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 90.00 B   | 17.03 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 89.00 B   | 16.84 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 85.00 B   | 16.08 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-instance                           | 85.00 B   | 16.08 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data                               | 81.00 B   | 15.33 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 78.00 B   | 14.76 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/utils                                     | 75.00 B   | 14.19 B    | 0.1           | 0.0

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '26.48 KB' │
│  compressed  │ '5.01 KB'  │
│ % Of Library │   '13.0'   │
└──────────────┴────────────┘
	Module                                                                      | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/relationships/state/relationship           | 8.30 KB   | 1.57 KB    | 31.4          | 4.1
	@ember-data/record-data/-private/record-data                                | 7.91 KB   | 1.50 KB    | 29.9          | 3.9
	@ember-data/record-data/-private/relationships/state/has-many               | 3.29 KB   | 638.04 B   | 12.4          | 1.6
	@ember-data/record-data/-private/relationships/state/belongs-to             | 3.22 KB   | 623.66 B   | 12.2          | 1.6
	@ember-data/record-data/-private/relationships/state/create                 | 1.15 KB   | 222.96 B   | 4.3           | 0.6
	@ember-data/record-data/-private/index                                      | 1023.00 B | 193.62 B   | 3.8           | 0.5
	@ember-data/record-data/-private/record-data-for                            | 481.00 B  | 91.04 B    | 1.8           | 0.2
	@ember-data/record-data/-private/ordered-set                                | 407.00 B  | 77.03 B    | 1.5           | 0.2
	@ember-data/record-data/-private/coerce-id                                  | 406.00 B  | 76.84 B    | 1.5           | 0.2
	@ember-data/record-data/-private/normalize-link                             | 249.00 B  | 47.12 B    | 0.9           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data     | 100.00 B  | 18.92 B    | 0.4           | 0.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.71 KB' │
│  compressed  │ '4.11 KB'  │
│ % Of Library │   '10.7'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.10 KB   | 1.34 KB    | 32.7          | 3.5
	@ember-data/serializer/-private/embedded-records-mixin     | 4.28 KB   | 830.35 B   | 19.7          | 2.1
	@ember-data/serializer/json-api                            | 3.71 KB   | 718.49 B   | 17.1          | 1.8
	@ember-data/serializer/rest                                | 2.70 KB   | 523.72 B   | 12.4          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 229.02 B   | 5.4           | 0.6
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 98.99 B    | 2.4           | 0.3
	@ember-data/serializer/-private/transforms/boolean         | 490.00 B  | 92.74 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 84.41 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 351.00 B  | 66.43 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 286.00 B  | 54.13 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 243.00 B  | 45.99 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 242.00 B  | 45.80 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 40.69 B    | 1.0           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.20 KB' │
│  compressed  │ '3.26 KB'  │
│ % Of Library │   '8.5'    │
└──────────────┴────────────┘
	Module                                                   | Bytes     | Compressed | % of Package  | % Of Library
	------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                         | 6.28 KB   | 1.19 KB    | 36.5          | 3.1
	@ember-data/model/-private/system/many-array             | 2.24 KB   | 434.00 B   | 13.0          | 1.1
	@ember-data/model/-private/errors                        | 1.92 KB   | 372.49 B   | 11.2          | 0.9
	@ember-data/model/-private/index                         | 1.29 KB   | 250.03 B   | 7.5           | 0.6
	@ember-data/model/-private/system/relationships/ext      | 1.19 KB   | 229.96 B   | 6.9           | 0.6
	@ember-data/model/-private/attr                          | 743.00 B  | 140.63 B   | 4.2           | 0.4
	@ember-data/model/-private/belongs-to                    | 663.00 B  | 125.48 B   | 3.8           | 0.3
	@ember-data/model/-private/has-many                      | 626.00 B  | 118.48 B   | 3.6           | 0.3
	@ember-data/model/-private/system/promise-many-array     | 611.00 B  | 115.64 B   | 3.5           | 0.3
	@ember-data/model/index                                  | 486.00 B  | 91.98 B    | 2.8           | 0.2
	@ember-data/model/-private/util                          | 443.00 B  | 83.84 B    | 2.5           | 0.2
	@ember-data/model/-private/system/promise-belongs-to     | 410.00 B  | 77.60 B    | 2.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin        | 404.00 B  | 76.46 B    | 2.3           | 0.2

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '16.39 KB' │
│  compressed  │ '3.10 KB'  │
│ % Of Library │   '8.1'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.67 KB   | 1.45 KB    | 46.8          | 3.8
	@ember-data/adapter/error                                     | 1.91 KB   | 370.79 B   | 11.7          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.80 KB   | 348.07 B   | 11.0          | 0.9
	@ember-data/adapter/-private/index                            | 1.03 KB   | 199.87 B   | 6.3           | 0.5
	@ember-data/adapter/json-api                                  | 830.00 B  | 157.09 B   | 4.9           | 0.4
	@ember-data/adapter/-private/utils/serialize-query-params     | 788.00 B  | 149.14 B   | 4.7           | 0.4
	@ember-data/adapter/index                                     | 719.00 B  | 136.08 B   | 4.3           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 90.85 B    | 2.9           | 0.2
	@ember-data/adapter/-private/utils/determine-body-promise     | 457.00 B  | 86.49 B    | 2.7           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 85.93 B    | 2.7           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 65.67 B    | 2.1           | 0.2

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.98 KB' │
│  compressed  │ '1.89 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 469.21 B   | 24.3          | 1.2
	ember-data/-private/index                         | 1.93 KB   | 373.63 B   | 19.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 230.34 B   | 11.9          | 0.6
	ember-data/setup-container                        | 503.00 B  | 95.20 B    | 4.9           | 0.2
	ember-data/store                                  | 406.00 B  | 76.84 B    | 4.0           | 0.2
	ember-data/-private/core                          | 321.00 B  | 60.75 B    | 3.1           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.18 B    | 3.1           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 51.86 B    | 2.7           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.50 B    | 2.5           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.37 B    | 2.4           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 45.99 B    | 2.4           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 45.99 B    | 2.4           | 0.1
	ember-data/transform                              | 241.00 B  | 45.61 B    | 2.4           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 44.85 B    | 2.3           | 0.1
	ember-data/serializer                             | 232.00 B  | 43.91 B    | 2.3           | 0.1
	ember-data/adapter                                | 226.00 B  | 42.77 B    | 2.2           | 0.1
	ember-data/model                                  | 222.00 B  | 42.01 B    | 2.2           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.26 B    | 2.1           | 0.1
	ember-data/initialize-store-service               | 207.00 B  | 39.18 B    | 2.0           | 0.1
	ember-data/version                                | 162.00 B  | 30.66 B    | 1.6           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.90 KB' │
│  compressed  │ '1.49 KB' │
│ % Of Library │   '3.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.75 KB   | 533.18 B   | 34.8          | 1.4
	ember-inflector/lib/system/inflections            | 1.57 KB   | 304.73 B   | 19.9          | 0.8
	ember-inflector/index                             | 1.12 KB   | 217.28 B   | 14.2          | 0.6
	ember-inflector/lib/ext/string                    | 783.00 B  | 148.20 B   | 9.7           | 0.4
	ember-inflector/lib/system                        | 452.00 B  | 85.55 B    | 5.6           | 0.2
	ember-inflector/lib/system/string                 | 351.00 B  | 66.43 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize             | 348.00 B  | 65.86 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 58.29 B    | 3.8           | 0.1
	ember-inflector/lib/helpers/singularize           | 271.00 B  | 51.29 B    | 3.4           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.68 KB'  │
│  compressed  │ '519.18 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.19 KB   | 424.73 B   | 81.8          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 94.44 B    | 18.2          | 0.2

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.05 KB'  │
│  compressed  │ '204.03 B' │
│ % Of Library │   '0.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                          | 1.05 KB   | 204.03 B   | 100.0         | 0.5

github-actions · 2019-12-02T10:46:01Z

Performance Report for 33ba6d5

Relationship Analysis

                        -------------

__/\\\\\\\\\\\\\____/\\\\____________/\\\\____/\\\\\\\\\_____
 _\/\\\/////////\\\_\/\\\\\\________/\\\\\\__/\\\///////\\\___
  _\/\\\_______\/\\\_\/\\\//\\\____/\\\//\\\_\///______\//\\\__
   _\/\\\\\\\\\\\\\/__\/\\\\///\\\/\\\/_\/\\\___________/\\\/___
    _\/\\\/////////____\/\\\__\///\\\/___\/\\\________/\\\//_____
     _\/\\\_____________\/\\\____\///_____\/\\\_____/\\\//________
      _\/\\\_____________\/\\\_____________\/\\\___/\\\/___________
       _\/\\\_____________\/\\\_____________\/\\\__/\\\\\\\\\\\\\\\_
        _\///______________\///______________\///__\///////////////__


                          Runtime Edition

        PM2 is a Production Process Manager for Node.js applications
                     with a built-in Load Balancer.

                Start and Daemonize any application:
                $ pm2 start app.js

                Load Balance 4 instances of api.js:
                $ pm2 start api.js -i 4

                Monitor in production:
                $ pm2 monitor

                Make pm2 auto-boot at server restart:
                $ pm2 startup

                To go further checkout:
                http://pm2.io/


                        -------------

[PM2] Spawning PM2 daemon with pm2_home=/home/runner/.pm2
[PM2] PM2 Successfully daemonized
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬──────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name     │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼──────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control  │ default     │ N/A     │ fork    │ 3088     │ 0s     │ 0    │ online    │ 0%       │ 33.4mb   │ runner   │ disabled │
└─────┴──────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬─────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name        │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼─────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control     │ default     │ N/A     │ fork    │ 3088     │ 0s     │ 0    │ online    │ 0%       │ 69.3mb   │ runner   │ disabled │
│ 1   │ experiment  │ default     │ N/A     │ fork    │ 3112     │ 0s     │ 0    │ online    │ 0%       │ 22.5mb   │ runner   │ disabled │
└─────┴─────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
Computing results...


┌───────────────────────────────────────────────────────────────────────┐
│ Initial Render : duration                                             │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1752ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 2000ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1780ms                 │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 1806ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1827ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1850ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1888ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1726ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 1990ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1774ms                 │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 1790ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1828ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1877ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1912ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ -1ms                         │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ -20ms to 18ms                │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁▁▂▄▆█▅▂▂▁▁▁▁▁▁              │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁▂▂█▃▄▄▁▂▄▁▁▁▁▁              │
└────────────────────────────────────────┴──────────────────────────────┘


┌───────────────────────────────────────────────────────────────────────┐
│ Sub Phase of Duration : start-find-all                                │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1246ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 1480ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1273ms                 │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 1288ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1308ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1333ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1343ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 1232ms                  │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 1480ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 1263ms                 │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 1280ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 1308ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 1338ms                 │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 1373ms                 │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ -2ms                         │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ -16ms to 13ms                │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁▁▄▇▇█▃▁▁▁▁▁▁▁               │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁▃▅█▅▅▂▃▁▂▁▁▁▁               │
├────────────────────────────────────────┴──────────────────────────────┤
│ Sub Phase of Duration : start-outer-materialization                   │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 450ms                   │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 592ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 474ms                  │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 483ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 490ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 504ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 529ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 450ms                   │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 566ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 471ms                  │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 477ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 492ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 503ms                  │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 517ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ -2ms                         │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ -9ms to 5ms                  │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁▂█▃▁▁▁▁                     │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁▅█▄▁▁▁▁                     │
├────────────────────────────────────────┴──────────────────────────────┤
│ Sub Phase of Duration : stop-outer-materialization                    │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 0ms                    │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 0ms                    │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 0ms                     │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 0ms                    │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 0ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 0ms                    │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 0ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ 0ms to 0ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ false                        │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▂█▅▅▃▁▁▁▁▁▁▁▁▁▁▁             │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▂██▃▆▂▂▁▁▁▁▁▁▁▁▁             │
├────────────────────────────────────────┴──────────────────────────────┤
│ Sub Phase of Duration : end-find-all                                  │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ Control: 60                  │
│ Sample Counts:                         ├──────────────────────────────┤
│                                        │ Experiment: 60               │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 20ms                    │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 34ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 20ms                   │
│                                        ├──────────────────────────────┤
│ Control Seven Figure Summary:          │ 25th: 21ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 21ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 23ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 25ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│                                        │ MIN: 20ms                    │
│                                        ├──────────────────────────────┤
│                                        │ MAX: 41ms                    │
│                                        ├──────────────────────────────┤
│                                        │ 10th: 20ms                   │
│                                        ├──────────────────────────────┤
│ Experiment Seven Figure Summary:       │ 25th: 21ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 50th: 23ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 75th: 26ms                   │
│                                        ├──────────────────────────────┤
│                                        │ 90th: 32ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Hodges–Lehmann estimated delta:        │ 1ms                          │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ 95% confident the delta is between:    │ 0ms to 2ms                   │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Is Significant:                        │ true                         │
├────────────────────────────────────────┴──────────────────────────────┤
│                                                                       │
├────────────────────────────────────────┬──────────────────────────────┤
│ Control Sparkline                      │ ▁█▃▂▁▁▁▁▁▁▁▁                 │
├────────────────────────────────────────┼──────────────────────────────┤
│ Experiment Sparkline                   │ ▁█▄▄▂▁▁▁▁▁▁▁                 │
└────────────────────────────────────────┴──────────────────────────────┘

    =========== Benchmark Results Summary ===========    
Red color means there was a regression. Green color means there was an improvement. You can view more statistical details about the phases above.

duration phase has no difference. 

start-find-all phase has no difference. 

start-outer-materialization phase has no difference. 

stop-outer-materialization phase has no difference. 

end-find-all phase has an estimated difference of +1ms. 

[PM2] [v] Modules Stopped
[PM2] Applying action deleteProcessId on app [all](ids: [ 0, 1 ])
[PM2] [control](0) ✓
[PM2] [experiment](1) ✓
[PM2] [v] All Applications Stopped
[PM2] [v] PM2 Daemon Stopped

Gaurav0

We may need to test our infra a bit more.

packages/unpublished-test-infra/index.js

runspired · 2019-12-05T21:06:09Z

RE tests, your suggestion of writing a test that asserts roughly:

let wasStripped = true;
if (DEPRECATE_SOMETHING) {
  wasStripped = false;
}

assert.ok(wasStripped);

looks great. We should find a way to implement this and then test several different flag levels (LTS 3.8 and 3.12 and then "everything" seem like good candidates). I'll open an issue to track that.

packages/-ember-data/ember-cli-build.js

packages/debug/index.js

packages/model/addon/-private/model.js

packages/private-build-infra/addon/current-deprecations.ts

packages/private-build-infra/src/create-version-module.js

packages/store/addon/-private/system/store/finders.js

packages/unpublished-test-infra/addon-test-support/deprecated-test.js

rwjblue · 2019-12-05T21:27:09Z

I also think we need to add documentation (somewhere) explaining how you opt in to this, what it does, etc.

runspired · 2019-12-05T21:37:54Z

@rwjblue ~~I'll open a ticket make sure we add api docs once it lands in stable.~~ added docs

runspired force-pushed the feat/deprecation-flags branch from 47c18d6 to a354cfd Compare November 27, 2019 20:45

emberjs deleted a comment from github-actions bot Nov 27, 2019

runspired force-pushed the feat/deprecation-flags branch from b90341f to e4c02d7 Compare November 27, 2019 21:12

runspired mentioned this pull request Nov 27, 2019

[CHORE] 11! #6819

Merged

runspired force-pushed the feat/deprecation-flags branch 2 times, most recently from 058f4e3 to 5adecfe Compare November 28, 2019 07:57

emberjs deleted a comment from github-actions bot Nov 28, 2019

runspired changed the title ~~[WIP FEAT] deprecation-infra~~ [FEAT] Strip resolved Deprecations Nov 28, 2019

runspired requested review from rwjblue and igorT November 28, 2019 08:21

runspired added 🏷️ cleanup This PR primarily removes deprecated functionality 🏷️ feat This PR introduces a new feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 CI labels Nov 28, 2019

runspired assigned igorT Nov 28, 2019

runspired force-pushed the feat/deprecation-flags branch from ab30a02 to dbdf3ac Compare November 30, 2019 01:38

runspired added 2 commits December 1, 2019 18:06

main infra

f38281b

strip deprecations

ae654fc

runspired force-pushed the feat/deprecation-flags branch from dbdf3ac to ae654fc Compare December 2, 2019 02:07

cleanup build

4ab93f2

more cleanup

cf9749c

Gaurav0 reviewed Dec 5, 2019

View reviewed changes

packages/unpublished-test-infra/index.js Show resolved Hide resolved

rwjblue reviewed Dec 5, 2019

View reviewed changes

runspired added 4 commits December 5, 2019 15:32

improve comment

da454e5

rename variable

b20da97

remove unneeded check

403049b

add docs for deprecations

33ba6d5

runspired merged commit 7485ba5 into master Dec 6, 2019

delete-merged-branch bot deleted the feat/deprecation-flags branch December 6, 2019 00:43

runspired mentioned this pull request Dec 6, 2019

Add tests for deprecation-infra #6858

Closed

runspired added Infra/CI/DX and removed CI labels Sep 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEAT] Strip resolved Deprecations #6814

[FEAT] Strip resolved Deprecations #6814

runspired commented Nov 27, 2019 •

edited

Loading

github-actions bot commented Nov 27, 2019 •

edited

Loading

github-actions bot commented Dec 2, 2019 •

edited

Loading

Gaurav0 left a comment

runspired commented Dec 5, 2019

rwjblue commented Dec 5, 2019

runspired commented Dec 5, 2019 •

edited

Loading

[FEAT] Strip resolved Deprecations #6814

[FEAT] Strip resolved Deprecations #6814

Conversation

runspired commented Nov 27, 2019 • edited Loading

github-actions bot commented Nov 27, 2019 • edited Loading

github-actions bot commented Dec 2, 2019 • edited Loading

Gaurav0 left a comment

Choose a reason for hiding this comment

runspired commented Dec 5, 2019

rwjblue commented Dec 5, 2019

runspired commented Dec 5, 2019 • edited Loading

runspired commented Nov 27, 2019 •

edited

Loading

github-actions bot commented Nov 27, 2019 •

edited

Loading

github-actions bot commented Dec 2, 2019 •

edited

Loading

runspired commented Dec 5, 2019 •

edited

Loading