Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BETA] Add environment variable to opt-out of rolling up -private #6312

Merged
merged 1 commit into from
Aug 14, 2019
Merged

[BETA] Add environment variable to opt-out of rolling up -private #6312

merged 1 commit into from
Aug 14, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 6, 2019

This allows us to:

  • Gather data about size per -private module
  • Gather usage details about each -private module (via Chrome's coverage stats)
  • Test the overall application performance impact of doing the rollup stages (do we still need them? how much impact does it have?)

@runspired
Copy link
Contributor

runspired commented Aug 7, 2019 •
edited
Loading

Once complete should resolve #6219

runspired
runspired reviewed Aug 7, 2019
View reviewed changes
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall +1 but disabling rollup will produce an issue that needs to be fixed (see issue I have linked), also there seems to be a lint error :)

@rwjblue
Copy link
Member Author

rwjblue commented Aug 8, 2019 •
edited
Loading

also there seems to be a lint error :)

Indeed, but its in a file I haven't touched 😩

$ eslint --plugin prettier .

/Users/vsts/agent/2.155.1/work/1/s/bin/publish.js
  145:33  error  Replace `⏎······?·'master'⏎······:·options.distTag·===·'latest'⏎······?·'release'⏎·····` with `·?·'master'·:·options.distTag·===·'latest'·?·'release'`  prettier/prettier

@rwjblue
Copy link
Member Author

rwjblue commented Aug 8, 2019

#6315 fixes that linting issue

@rwjblue @igorT
[BETA] Add environment variable to opt-out of rolling up -private
d3fc47e 
This allows us to:

* Gather data about size per `-private` module
* Gather usage details about each `-private` module (via Chrome's
  coverage stats)
* Test the overall application performance impact of doing the `rollup`
  stages (do we still need them? how much impact does it have?)
@igorT igorT force-pushed the allow-disabling-rollup branch from 0b7d50b to d3fc47e Compare August 14, 2019 19:48
@igorT igorT merged commit 83e9743 into emberjs:master Aug 14, 2019
igorT pushed a commit that referenced this pull request Sep 5, 2019
@rwjblue @igorT
[BETA] Add environment variable to opt-out of rolling up -private (#…
73707ba 
…6312)

This allows us to:

* Gather data about size per `-private` module
* Gather usage details about each `-private` module (via Chrome's
  coverage stats)
* Test the overall application performance impact of doing the `rollup`
  stages (do we still need them? how much impact does it have?)
igorT pushed a commit that referenced this pull request Sep 6, 2019
@rwjblue @igorT
[BETA] Add environment variable to opt-out of rolling up -private (#…
77c0c7c 
…6312)

This allows us to:

* Gather data about size per `-private` module
* Gather usage details about each `-private` module (via Chrome's
  coverage stats)
* Test the overall application performance impact of doing the `rollup`
  stages (do we still need them? how much impact does it have?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwjblue @runspired @igorT