Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldRollupPrivate: false produces a broken build #6219

Closed
ef4 opened this issue Jul 3, 2019 · 1 comment · Fixed by #6528
Closed

shouldRollupPrivate: false produces a broken build #6219

ef4 opened this issue Jul 3, 2019 · 1 comment · Fixed by #6528

Comments

@ef4
Copy link
Contributor

ef4 commented Jul 3, 2019

I realize this may not be public API, but the shouldRollupPrivate flag that now exists in @ember-data/-build-infra doesn't appear to work.

The problem is that if you set it to false, you get a build that lacks the version.js file.
@runspired
Copy link
Contributor

Sounds like a good thing to fix but confirm it should not be public.

@runspired runspired mentioned this issue Aug 7, 2019
Merged
@runspired runspired mentioned this issue Sep 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] only include version in ember-data output emberjs/data
2 participants
@ef4 @runspired