Added more models to Email.js #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meets2tarun
reviewed
Jun 10, 2018
models/doctype/Email/Email.js
Outdated
| "fieldname": "emailAddress", | ||
| "label": "bcc", | ||
| "fieldtype": "Data", | ||
| "required": 1 |
There was a problem hiding this comment.
In case if someone doesn't want to provide any bcc address.
meets2tarun
reviewed
Jun 10, 2018
models/doctype/Email/Email.js
Outdated
| "fieldname": "emailAddress", | ||
| "label": "cc", | ||
| "fieldtype": "Data", | ||
| "required": 1 |
There was a problem hiding this comment.
If someone doesn't want to provide a cc address.
|
oops, I'll make changes to cc, bcc and make PR again! |
|
Done @meets2tarun |
meets2tarun
reviewed
Jun 10, 2018
| "fieldname": "Content", | ||
| "label": "", | ||
| "fieldtype" : "Text", | ||
| "required": 0 |
There was a problem hiding this comment.
I think this is body, so I'm not sure whether a mail can be send without a body.
There was a problem hiding this comment.
Blank mails are allowed @meets2tarun . However, for blank subject, we might have to add a warning/prompt later "Send mail without any subject", but maybe we'll deal with that while adding interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.