Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more models to Email.js #8

Merged
merged 2 commits into from
Jun 10, 2018
Merged

Added more models to Email.js #8

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0182c15
Update Email.js
accakks Jun 10, 2018
9410484
Changes made in cc, bcc fields in models
accakks Jun 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 35 additions & 3 deletions models/doctype/Email/Email.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module.exports = {
},
{
"fieldname": "emailAddress",
"label": "Email Address",
"label": "from",
"fieldtype": "Data",
"required": 1
},
Expand All @@ -38,6 +38,38 @@ module.exports = {
"label": "Port",
"fieldtype": "Int",
"required": 1
}
},
{
"fieldname": "emailAddress",
"label": "to",
"fieldtype": "Data",
"required": 1
},
{
"fieldname": "emailAddress",
"label": "cc",
"fieldtype": "Data",
"required": 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone doesn't want to provide a cc address.

},
{
"fieldname": "emailAddress",
"label": "bcc",
"fieldtype": "Data",
"required": 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case if someone doesn't want to provide any bcc address.

},
{
"fieldname": "Subject",
"label": "Subject",
"fieldtype" : "Text",
"required": 0
},
{
"fieldname": "Content",
"label": "",
"fieldtype" : "Text",
"required": 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is body, so I'm not sure whether a mail can be send without a body.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank mails are allowed @meets2tarun . However, for blank subject, we might have to add a warning/prompt later "Send mail without any subject", but maybe we'll deal with that while adding interface

}


]
}
}