Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remaining notebook imports to jupyter_server #1471

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Update remaining notebook imports to jupyter_server #1471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions elyra/pipeline/http_kernel_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
from jupyter_client.manager import AsyncKernelManager
from jupyter_client.managerabc import KernelManagerABC
from logging import Logger
from notebook.gateway.managers import GatewayClient, gateway_request
from notebook.utils import url_path_join, maybe_future
from jupyter_server.gateway.managers import GatewayClient, gateway_request
from jupyter_server.utils import url_path_join, ensure_async
from queue import Queue
from threading import Thread
from tornado import web
Expand Down Expand Up @@ -308,7 +308,7 @@ async def start_channels(self, shell=True, iopub=True, stdin=True, hb=True, cont
self.response_router = Thread(target=self._route_responses)
self.response_router.start()

await maybe_future(super().start_channels(shell=shell, iopub=iopub, stdin=stdin, hb=hb, control=control))
await ensure_async(super().start_channels(shell=shell, iopub=iopub, stdin=stdin, hb=hb, control=control))

def stop_channels(self):
"""Stops all the running channels for this kernel.
Expand Down
2 changes: 1 addition & 1 deletion elyra/pipeline/processor_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from abc import ABC, abstractmethod
from elyra.pipeline import PipelineProcessor, PipelineProcessorResponse, Operation
from elyra.util.path import get_absolute_path
from notebook.gateway.managers import GatewayClient
from jupyter_server.gateway.managers import GatewayClient
from subprocess import run, CalledProcessError, PIPE
from traitlets import log
from typing import Dict
Expand Down