Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remaining notebook imports to jupyter_server #1471

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

kevin-bates
Copy link
Member

Updated a couple more instances of notebook import statements to reflect the jupyter_server location. The problem was because we use GatewayClient from the "running server" to determine whether a gateway server is configured or not and, if so, the configuration settings to use (URL, timeouts, etc.). Since this is a singleton and the reference is from the notebook package, yet jupyter_server is running, the notebook-relative singleton will not reflect the current configuration.

Fixes #1470

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@elyra-bot
Copy link

elyra-bot bot commented Mar 23, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende lresende added this to the 2.2.0 milestone Mar 24, 2021
@lresende lresende merged commit 5664d53 into elyra-ai:master Mar 24, 2021
@kevin-bates kevin-bates deleted the notebook-to-server branch September 11, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnterpriseGateway integration is broken (since 2.x)
2 participants