Add scaling support to converter and decoder #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
requested changes
Jan 19, 2025
test/video_converter_test.exs
Outdated
|
|
||
| assert byte_size(ref_frame1) == 480 * 360 * 3 | ||
| assert byte_size(ref_frame2) == 360 * 240 * 3 | ||
| end | ||
|
|
||
| test "scale video frame", %{frame_480p: frame_480p} do | ||
| converter = Xav.VideoConverter.new!(width: 368) |
There was a problem hiding this comment.
check incorrrect width and height
There was a problem hiding this comment.
Should we add validation on the elixir code ? since we don't initialize the converter on creation ffmpeg won't do any validation until you first try to convert a frame.
There was a problem hiding this comment.
Just this thing and we are ready to merge
|
@mickel8 since we're raising in the |
|
Thanks! |
|
@gBillal looks like somethings failes on macos-arm. Do you have any means to check what's wrong? It looks like scaled binary does not match 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #25