Add video converter #25
Conversation
|
@gBillal Sorry for no response. I will try to merge this tomorrow! |
c_src/xav/xav_video_converter.c
Outdated
| enum AVPixelFormat out_pix_fmt = av_get_pix_fmt(out_format); | ||
|
|
||
| if (in_pix_fmt == AV_PIX_FMT_NONE || out_pix_fmt == AV_PIX_FMT_NONE) { | ||
| ret = xav_nif_error(env, "unknown_format"); |
There was a problem hiding this comment.
Let's raise here instead. We do a similar thing for decoder when user passes unsupported codec.
There was a problem hiding this comment.
I updated it to raise however I think we should return an error because we don't have the list of available formats in the documentation or in the code where we can do the validation in Elixir code.
| return -1; | ||
| } | ||
|
|
||
| return video_converter_init(xav_decoder->vc, frame->width, frame->height, |
There was a problem hiding this comment.
if this fails, we need to free video_converter. I can see that I implemented audio the same way but I think that's a bug
There was a problem hiding this comment.
Okay, maybe that's not a bug as in our case, decoder's destructor will do the thing but I think we should fix this anyway i.e. free converter and leave xav_decoder->vc untouched.
There was a problem hiding this comment.
Yes the destructor will free the converter in case of error.
|
Thanks!! 🎉 |
In this PR, we extract the video converter into its own struct and expose an Elixir module to convert pixel format of video samples.
The next step would be adding scaling