Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum Node version to 6 #6

Merged
merged 4 commits into from
Jul 17, 2018
Merged

Increase minimum Node version to 6 #6

merged 4 commits into from
Jul 17, 2018

Conversation

malept
Copy link
Member

@malept malept commented Apr 7, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Node 4 loses LTS status on 2018-04-30.

@welcome
Copy link

welcome bot commented Apr 7, 2018

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

Node 4 loses LTS status on 2018-04-30.
@codecov
Copy link

codecov bot commented Apr 7, 2018

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #6   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         242    242           
=====================================
  Hits          242    242
Impacted Files Coverage Δ
src/snapcraft.js 100% <ø> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️
src/yaml.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6712b9b...efcf36e. Read the comment docs.

@malept malept changed the title [WIP] Increase minimum Node version to 6 Increase minimum Node version to 6 Jul 17, 2018
@malept malept merged commit 3142b12 into master Jul 17, 2018
@malept malept deleted the drop-node-4 branch July 17, 2018 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants