Increase minimum Node version to 6

Node 4 loses LTS status on 2018-04-30.
electron-userland · Apr 5, 2018 · 5cd3de6 · 5cd3de6
1 parent 6712b9b
commit 5cd3de6
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,10 @@
 
 [Unreleased]: https://github.com/electron-userland/electron-installer-snap/compare/v2.0.1...master
 
+## Changed
+
+* Minimum Node version increased to Node 6, as Node 4 is no longer LTS
+
 ## [2.0.1] - 2018-02-22
 
 [2.0.1]: https://github.com/electron-userland/electron-installer-snap/compare/v2.0.0...v2.0.1

diff --git a/README.md b/README.md
@@ -7,7 +7,7 @@ Builds Snap files for Electron applications that have already been bundled and c
 
 ## Requirements
 
-Requires Node 4 or greater, and [`snapcraft`](https://snapcraft.io).
+Requires Node 6 or greater, and [`snapcraft`](https://snapcraft.io).
 
 ## Quick Start
 

diff --git a/package.json b/package.json
@@ -57,7 +57,7 @@
     "yargs": "^11.0.0"
   },
   "engines": {
-    "node": ">= 4.0"
+    "node": ">= 6.0"
   },
   "eslintConfig": {
     "extends": [

diff --git a/src/cli.js b/src/cli.js
@@ -80,7 +80,7 @@ function parseArgs () {
   const YARGS_KEYS = ['_', '$0', 'help']
   for (const key in args) {
     const value = args[key]
-    if (value !== undefined && key.indexOf('-') === -1 && YARGS_KEYS.indexOf(key) === -1) {
+    if (value !== undefined && !key.includes('-') && !YARGS_KEYS.includes(key)) {
       filteredArgs[key] = value
     }
   }

diff --git a/test/_util.js b/test/_util.js
@@ -20,11 +20,11 @@ const test = require('ava')
 const tmp = require('tmp-promise')
 
 function assertIncludes (t, collection, value, message) {
-  return t.not(collection.indexOf(value), -1, message)
+  return t.true(collection.includes(value), message)
 }
 
 function assertNotIncludes (t, collection, value, message) {
-  return t.is(collection.indexOf(value), -1, message)
+  return t.false(collection.includes(value), message)
 }
 
 test.beforeEach(t => {