This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Refactor configuration #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
balegas
reviewed
Oct 31, 2022
src/drivers/absurd-sql/index.ts
Outdated
| @@ -48,7 +48,7 @@ export const initElectricSqlJs = async (worker: Worker, locateOpts: LocateFileOp | |||
| await workerClient.request(init, locator.serialise()) | |||
|
|
|||
| // we remove opts type info here to implement target interface | |||
There was a problem hiding this comment.
Can you remove this comment.
I tried separating the config from the opts but it would not implement the target interface.
I see there is not the same problem now, but I also see that this ElectrifyOptions still has the config. That is not the idea right? -- you might enter the same problems that I did, if you try to refactor this type.
There was a problem hiding this comment.
oops. yeah. forgot to remove the config from the ElectrifyOptions interface
balegas
approved these changes
Oct 31, 2022
Replace ElectrifyOptions with a {ElectricConfig, ElectrifyOptions}
params.
otherwise its difficult to pass in generated configuration like the authentication token
f3144db to
d6f68ff
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace ElectrifyOptions with a {ElectricConfig, ElectrifyOptions} params.