Fix browser example configuration #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balegas
reviewed
Oct 31, 2022
There was a problem hiding this comment.
Is this required for current typescript-client, or just with electric-sql/typescript-client#26?
|
I suppose from the comment it is just with the PR.
|
balegas
approved these changes
Nov 29, 2022
cf39fd8 to
451af6d
Compare
451af6d to
7f7e9e3
Compare
|
@balegas think this is now good to go |
|
Is this good to merge? |
|
All good from my side Garry. Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see electric-sql/typescript-client#26