-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation of the logstash.yml settings file #4856
Conversation
On it. |
# Set the number of workers that will, in parallel, execute the filters+outputs | ||
# stage of the pipeline. | ||
# | ||
# This defaults to half the number of the host's CPU cores. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we have changed that to use all the core.
@jsvd I like the code, I think the only thing I would try to squeak in for this PR is to encapsulate this logic into his own class like a Config or a Settings class and we could make it behave like hash/Enum for the accessors. Doing this would allow us future improvements PR with this:
|
I think most of the suggestions/ideas could be encapsulated in the config object and add improvements to the config system without having to change anything else in the core classes, except the one removing clamp :P |
closed in favor of #5251 |
This settings.yml located at LOGSTASH_HOME will override the defaults settings but can still be overridden itself by command line arguments.
So the setting precedence is, from weakest to strongest: default settings < yaml settings < cli settings
TODO
make conf/logstash.yml location configurable using env var CONF_DIR or similar