[Fleet] Hide Fleet Server policies in standalone agent instructions #98787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/fleet (Feature:Fleet) |
jen-huang
approved these changes
Apr 29, 2021
Comment on lines
57
to
62
| const showFleetServerWarning = | ||
| excludeFleetServer && packages.some((pkg) => pkg.name === FLEET_SERVER_PACKAGE); | ||
|
|
||
| const collectedIntegrationsCount = packages.filter( | ||
| (pkg) => !excludeFleetServer || pkg.name !== FLEET_SERVER_PACKAGE | ||
| ).length; |
There was a problem hiding this comment.
nit: would be good to useMemo() these
| 'xpack.fleet.agentReassignPolicy.packageBadgeFleetServerWarning', | ||
| { | ||
| defaultMessage: | ||
| 'The Fleet Server integration will not collect data in standalone mode.', |
There was a problem hiding this comment.
Suggested change
| 'The Fleet Server integration will not collect data in standalone mode.', | |
| 'Fleet Server will not be enabled in standalone mode.', |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @Zacqary |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 29, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #97707
Hides agent policies with
is_default_fleet_server: truein theRun standaloneflyout:And shows a warning for other policies with the Fleet Server integration: