Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Hide Fleet Server policies in standalone agent instructions #97707

Closed
jen-huang opened this issue Apr 20, 2021 · 6 comments · Fixed by #98787
Closed

[Fleet] Hide Fleet Server policies in standalone agent instructions #97707

jen-huang opened this issue Apr 20, 2021 · 6 comments · Fixed by #98787
Assignees
Labels
bug Fixes for quality problems that affect the customer experience low hanging fruit DO NOT USE. Use `good first issue` instead Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jen-huang
Copy link
Contributor

From discussion in this PR: #97681 (comment)

We now show Fleet Server-specific instructions for the user when they select an agent policy that contains Fleet Server. These instructions are shown in Enroll in Fleet tab aka managed mode with the assumption that the user will want to see their Fleet Server agent in Kibana.

But what about for Run standalone tab where we show instructions for enrolling standalone agents? Is there ever a use case for a "standalone Fleet Server"? Probably not, so we should consider hiding Fleet Server agent policies from the selection dropdown on that tab.

cc @mostlyjason

@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@ruflin
Copy link
Contributor

ruflin commented Apr 21, 2021

Fleet-Server is only used in the managed mode. It should not show up in standalone.

@jen-huang jen-huang added bug Fixes for quality problems that affect the customer experience low hanging fruit DO NOT USE. Use `good first issue` instead labels Apr 26, 2021
@Zacqary Zacqary self-assigned this Apr 28, 2021
@Zacqary
Copy link
Contributor

Zacqary commented Apr 29, 2021

Is this a simple check to hide policies with is_default_fleet_server: true or do we need to poll the package policies to see if they have the Fleet Server integration added?

@jen-huang
Copy link
Contributor Author

@Zacqary In my mind all policies that contain fleet_server package should be excluded. The reason is because the instructions for standing up an agent with Fleet Server is different than normal agents and there is no concept of a "stand alone Fleet Server agent".

@Zacqary
Copy link
Contributor

Zacqary commented Apr 29, 2021

@jen-huang The way the UI works right now is that it fetches the integration packages after the user selects the policy from the dropdown. With that in mind, I wonder if it would make sense to:

  • Hide is_default_fleet_server policies
  • Show all other policies, but display any fleet_server package badges in red and display a warning indicating that fleet_server won't work in standalone mode (but other packages will)

@jen-huang
Copy link
Contributor Author

@Zacqary 👍🏻 That proposal sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience low hanging fruit DO NOT USE. Use `good first issue` instead Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants