[Discover] Fix wrong sort order with empty sort URL parameter #97434

kertal · 2021-04-19T10:26:43Z

Summary

From 7.7.0 to 7.11.0

An empty sort array -> sort:!()) was set in the URL, until the user changed sorting actively. the default sorting was calculated for UI and request, but not added to state, and was therefore not part of the URL.

7.12

In 7.12 the default sorting behavior was changed by #85561
It was possible to "unsort" the document table, this was needed for the data grid implementation.

Using legacy grid it was not possible to "unsort" using the UI.

The issue with invalid sorting behavior as a result of 7.12 changes

If there was a link of a recent version used in 7.12 containing sort:!()), this led to the following behavior:

The empty array provided by sort:!()) in the URL was overwriting the sort array provided by the default state (which contained the default sorting). Documents were requested unsorted. In UI it was still indicated, that it's sorted by the index pattern's default sorting (e.g. @timestamp).

Testing

Replace the sort part of a Discover url containing an index pattern with timefield with sort:!()), open this URL
Everything should work as expected, while before this fix, the sort part of the request sent to Elasticsearch was sorting by _doc

fixes #97456

Checklist

Unit or functional tests were updated or added to match the most common scenarios

kertal · 2021-04-20T08:56:45Z

@elasticmachine merge upstream

…state-sort-handling

kertal · 2021-04-20T09:58:56Z

@elasticmachine merge upstream

…state-sort-handling

…-19-discover-fix-initial-state-sort-handling

…ndling' of github.com:kertal/kibana into kertal-pr-2021-04-19-discover-fix-initial-state-sort-handling

src/plugins/discover/public/application/angular/discover_state.ts

timroes

Tested on Chrome Linux. This will now sort an empty query by timestamp again. Though it will change the URL when loaded to contain that timestamp in it. I don't see how that could cause an issue thus I think that's new behavior is fine. PR LGTM once tests are green.

Co-authored-by: Tim Roes <mail@timroes.de>

kibanamachine · 2021-04-20T18:27:05Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 828d75d
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup7

Test Failures

Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/sync_colors·ts.dashboard sync colors should sync colors on dashboard by default

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 3 times on tracked branches: https://github.com/elastic/kibana/issues/97403

[00:00:00]       │
[00:00:00]         └-: dashboard
[00:00:00]           └-> "before all" hook in "dashboard"
[00:19:11]           └-: sync colors
[00:19:11]             └-> "before all" hook for "should sync colors on dashboard by default"
[00:19:11]             └-> "before all" hook for "should sync colors on dashboard by default"
[00:19:11]               │ info [logstash_functional] Loading "mappings.json"
[00:19:11]               │ info [logstash_functional] Loading "data.json.gz"
[00:19:11]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:19:11]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:19:11]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:19:12]               │ info [lens/basic] Loading "mappings.json"
[00:19:12]               │ info [lens/basic] Loading "data.json"
[00:19:12]               │ info [lens/basic] Loading "data.json.gz"
[00:19:12]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_pre6.5.0_001/2BFV-EFrSdKfAVmnoVkxsw] deleting index
[00:19:12]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_8.0.0_001/AfUSQ8SSSa--pHVhTR2p5w] deleting index
[00:19:12]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_task_manager_8.0.0_001/G7wi6ERHS2-sZKRGkmFNiw] deleting index
[00:19:12]               │ info [lens/basic] Deleted existing index ".kibana_8.0.0_001"
[00:19:12]               │ info [lens/basic] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:19:12]               │ info [lens/basic] Deleted existing index ".kibana_pre6.5.0_001"
[00:19:12]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_1] creating index, cause [api], templates [], shards [1]/[0]
[00:19:12]               │ info [lens/basic] Created index ".kibana_1"
[00:19:12]               │ debg [lens/basic] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:19:12]               │ info [lens/basic] Indexed 24 docs into ".kibana_1"
[00:19:12]               │ debg Migrating saved objects
[00:19:12]               │ proc [kibana]   log   [17:14:22.386] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET. took: 6ms.
[00:19:12]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:19:12]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:19:12]               │ proc [kibana]   log   [17:14:22.400] [info][savedobjects-service] [.kibana] INIT -> WAIT_FOR_YELLOW_SOURCE. took: 21ms.
[00:19:12]               │ proc [kibana]   log   [17:14:22.414] [info][savedobjects-service] [.kibana] WAIT_FOR_YELLOW_SOURCE -> SET_SOURCE_WRITE_BLOCK. took: 14ms.
[00:19:12]               │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] adding block write to indices [[.kibana_1/Uua5loNcQXGqhoT0To5SpQ]]
[00:19:12]               │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] completed adding block write to indices [.kibana_1]
[00:19:12]               │ proc [kibana]   log   [17:14:22.457] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY. took: 71ms.
[00:19:12]               │ proc [kibana]   log   [17:14:22.477] [info][savedobjects-service] [.kibana] SET_SOURCE_WRITE_BLOCK -> CREATE_REINDEX_TEMP. took: 63ms.
[00:19:12]               │ proc [kibana]   log   [17:14:22.484] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE. took: 27ms.
[00:19:12]               │ proc [kibana]   log   [17:14:22.485] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 105ms
[00:19:12]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_8.0.0_reindex_temp] creating index, cause [api], templates [], shards [1]/[1]
[00:19:12]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] updating number_of_replicas to [0] for indices [.kibana_8.0.0_reindex_temp]
[00:19:12]               │ proc [kibana]   log   [17:14:22.533] [info][savedobjects-service] [.kibana] CREATE_REINDEX_TEMP -> REINDEX_SOURCE_TO_TEMP. took: 56ms.
[00:19:12]               │ proc [kibana]   log   [17:14:22.541] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP -> REINDEX_SOURCE_TO_TEMP_WAIT_FOR_TASK. took: 8ms.
[00:19:12]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_8.0.0_reindex_temp/Vr7b2rWlTjucrON4o_ljxw] update_mapping [_doc]
[00:19:12]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_8.0.0_reindex_temp/Vr7b2rWlTjucrON4o_ljxw] update_mapping [_doc]
[00:19:12]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_8.0.0_reindex_temp/Vr7b2rWlTjucrON4o_ljxw] update_mapping [_doc]
[00:19:12]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] 31370 finished with response BulkByScrollResponse[took=82.5ms,timed_out=false,sliceId=null,updated=0,created=12,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:19:12]               │ proc [kibana]   log   [17:14:22.649] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_WAIT_FOR_TASK -> SET_TEMP_WRITE_BLOCK. took: 108ms.
[00:19:12]               │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] adding block write to indices [[.kibana_8.0.0_reindex_temp/Vr7b2rWlTjucrON4o_ljxw]]
[00:19:12]               │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] completed adding block write to indices [.kibana_8.0.0_reindex_temp]
[00:19:12]               │ proc [kibana]   log   [17:14:22.689] [info][savedobjects-service] [.kibana] SET_TEMP_WRITE_BLOCK -> CLONE_TEMP_TO_TARGET. took: 40ms.
[00:19:12]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] applying create index request using existing index [.kibana_8.0.0_reindex_temp] metadata
[00:19:12]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_8.0.0_001] creating index, cause [clone_index], templates [], shards [1]/[1]
[00:19:12]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] updating number_of_replicas to [0] for indices [.kibana_8.0.0_001]
[00:19:13]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_8.0.0_001/SXLMaS2oSzO93YS4NIwoLQ] create_mapping
[00:19:13]               │ proc [kibana]   log   [17:14:22.782] [info][savedobjects-service] [.kibana] CLONE_TEMP_TO_TARGET -> OUTDATED_DOCUMENTS_SEARCH. took: 93ms.
[00:19:13]               │ proc [kibana]   log   [17:14:22.797] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH -> OUTDATED_DOCUMENTS_TRANSFORM. took: 15ms.
[00:19:13]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_8.0.0_001/SXLMaS2oSzO93YS4NIwoLQ] update_mapping [_doc]
[00:19:13]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_8.0.0_001/SXLMaS2oSzO93YS4NIwoLQ] update_mapping [_doc]
[00:19:14]               │ proc [kibana]   log   [17:14:23.731] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_TRANSFORM -> OUTDATED_DOCUMENTS_SEARCH. took: 934ms.
[00:19:14]               │ proc [kibana]   log   [17:14:23.742] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH -> UPDATE_TARGET_MAPPINGS. took: 11ms.
[00:19:14]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_8.0.0_001/SXLMaS2oSzO93YS4NIwoLQ] update_mapping [_doc]
[00:19:14]               │ proc [kibana]   log   [17:14:23.803] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK. took: 61ms.
[00:19:14]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] 31450 finished with response BulkByScrollResponse[took=22.4ms,timed_out=false,sliceId=null,updated=12,created=0,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:19:14]               │ proc [kibana]   log   [17:14:23.917] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> MARK_VERSION_INDEX_READY. took: 114ms.
[00:19:14]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-centos-tests-xxl-1618935789582406348] [.kibana_8.0.0_reindex_temp/Vr7b2rWlTjucrON4o_ljxw] deleting index
[00:19:14]               │ proc [kibana]   log   [17:14:23.960] [info][savedobjects-service] [.kibana] MARK_VERSION_INDEX_READY -> DONE. took: 43ms.
[00:19:14]               │ proc [kibana]   log   [17:14:23.960] [info][savedobjects-service] [.kibana] Migration completed after 1581ms
[00:19:14]               │ debg [lens/basic] Migrated Kibana index after loading Kibana data
[00:19:14]               │ debg [lens/basic] Ensured that default space exists in .kibana
[00:19:14]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true}
[00:19:16]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true}
[00:19:17]             └-> should sync colors on dashboard by default
[00:19:17]               └-> "before each" hook: global before each for "should sync colors on dashboard by default"
[00:19:17]               │ debg navigating to dashboard url: http://localhost:6111/app/dashboards#/list
[00:19:17]               │ debg navigate to: http://localhost:6111/app/dashboards#/list
[00:19:17]               │ debg browser[INFO] http://localhost:6111/app/dashboards?_t=1618938866761#/list 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:19:17]               │
[00:19:17]               │ debg browser[INFO] http://localhost:6111/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:19:17]               │ debg ... sleep(700) start
[00:19:17]               │ debg ... sleep(700) end
[00:19:17]               │ debg returned from get, calling refresh
[00:19:18]               │ debg browser[INFO] http://localhost:6111/app/dashboards?_t=1618938866761#/list 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:19:18]               │
[00:19:18]               │ debg browser[INFO] http://localhost:6111/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:19:18]               │ debg currentUrl = http://localhost:6111/app/dashboards#/list
[00:19:18]               │          appUrl = http://localhost:6111/app/dashboards#/list
[00:19:18]               │ debg TestSubjects.find(kibanaChrome)
[00:19:18]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:19:19]               │ debg ... sleep(501) start
[00:19:20]               │ debg ... sleep(501) end
[00:19:20]               │ debg in navigateTo url = http://localhost:6111/app/dashboards#/list?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:19:20]               │ debg TestSubjects.exists(statusPageContainer)
[00:19:20]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:19:22]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:19:23]               │ debg TestSubjects.click(createDashboardPromptButton)
[00:19:23]               │ debg Find.clickByCssSelector('[data-test-subj="createDashboardPromptButton"]') with timeout=10000
[00:19:23]               │ debg Find.findByCssSelector('[data-test-subj="createDashboardPromptButton"]') with timeout=10000
[00:19:23]               │ debg DashboardAddPanel.clickAddNewPanelButton
[00:19:23]               │ debg TestSubjects.click(dashboardAddNewPanelButton)
[00:19:23]               │ debg Find.clickByCssSelector('[data-test-subj="dashboardAddNewPanelButton"]') with timeout=10000
[00:19:23]               │ debg Find.findByCssSelector('[data-test-subj="dashboardAddNewPanelButton"]') with timeout=10000
[00:19:23]               │ debg ... sleep(500) start
[00:19:24]               │ debg ... sleep(500) end
[00:19:24]               │ debg isGlobalLoadingIndicatorVisible
[00:19:24]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:19:24]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:19:24]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:19:24]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:19:24]               │ debg lensPage.goToTimeRange()
[00:19:24]               │ debg TestSubjects.exists(noDataPopoverDismissButton)
[00:19:24]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="noDataPopoverDismissButton"]') with timeout=2500
[00:19:26]               │ debg --- retry.tryForTime error: [data-test-subj="noDataPopoverDismissButton"] is not displayed
[00:19:27]               │ debg Setting absolute range to Sep 19, 2015 @ 06:31:44.000 to Sep 23, 2015 @ 18:31:44.000
[00:19:27]               │ debg TestSubjects.exists(superDatePickerToggleQuickMenuButton)
[00:19:27]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=20000
[00:19:27]               │ debg TestSubjects.exists(superDatePickerShowDatesButton)
[00:19:27]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=2500
[00:19:27]               │ debg TestSubjects.click(superDatePickerShowDatesButton)
[00:19:27]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:19:27]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:19:27]               │ debg TestSubjects.exists(superDatePickerstartDatePopoverButton)
[00:19:27]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=2500
[00:19:27]               │ debg TestSubjects.click(superDatePickerendDatePopoverButton)
[00:19:27]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:19:27]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:19:27]               │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:19:27]               │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:19:27]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:19:27]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:19:27]               │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:19:27]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:27]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:27]               │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 23, 2015 @ 18:31:44.000)
[00:19:27]               │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:19:27]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:27]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:28]               │ debg TestSubjects.click(superDatePickerstartDatePopoverButton)
[00:19:28]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:19:28]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:19:28]               │ debg Find.waitForElementStale with timeout=10000
[00:19:28]               │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:19:28]               │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:19:28]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:19:28]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:19:28]               │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:19:28]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:28]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:28]               │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 19, 2015 @ 06:31:44.000)
[00:19:28]               │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:19:28]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:28]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:19:29]               │ debg TestSubjects.exists(superDatePickerApplyTimeButton)
[00:19:29]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=2500
[00:19:31]               │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerApplyTimeButton"] is not displayed
[00:19:32]               │ debg TestSubjects.click(querySubmitButton)
[00:19:32]               │ debg Find.clickByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:19:32]               │ debg Find.findByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:19:32]               │ debg Find.waitForElementStale with timeout=10000
[00:19:32]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:19:32]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:19:32]               │ debg lensPage.configureDimension([object Object])
[00:19:32]               │ debg TestSubjects.click(lns-layerPanel-0 > lnsXY_yDimensionPanel > lns-empty-dimension)
[00:19:32]               │ debg Find.clickByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:19:32]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:19:42]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:19:42]               │      Wait timed out after 10006ms
[00:19:43]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:19:53]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:19:53]               │      Wait timed out after 10021ms
[00:19:53]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:20:03]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:20:03]               │      Wait timed out after 10022ms
[00:20:04]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:20:14]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:20:14]               │      Wait timed out after 10056ms
[00:20:14]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:20:24]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:20:24]               │      Wait timed out after 10007ms
[00:20:25]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:20:35]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:20:35]               │      Wait timed out after 10043ms
[00:20:35]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:20:45]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:20:45]               │      Wait timed out after 10045ms
[00:20:46]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:20:56]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:20:56]               │      Wait timed out after 10004ms
[00:20:56]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:21:06]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:06]               │      Wait timed out after 10022ms
[00:21:07]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:21:17]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:17]               │      Wait timed out after 10037ms
[00:21:17]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:21:28]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:28]               │      Wait timed out after 10041ms
[00:21:28]               │ debg Find.findByCssSelector('[data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"]') with timeout=10000
[00:21:38]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:38]               │      Wait timed out after 10026ms
[00:21:39]               │ debg --- retry.try error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:39]               │      Wait timed out after 10026ms
[00:21:39]               │          at /dev/shm/workspace/parallel/1/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:21:39]               │          at runMicrotasks (<anonymous>)
[00:21:39]               │          at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:21:39]               │ info Taking screenshot "/dev/shm/workspace/parallel/1/kibana/x-pack/test/functional/screenshots/failure/dashboard sync colors should sync colors on dashboard by default.png"
[00:21:39]               │ info Current URL is: http://localhost:6111/app/dashboards#/create?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-19T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(description:%27%27,filters:!(),fullScreenMode:!f,options:(hidePanelTitles:!f,useMargins:!t),query:(language:kuery,query:%27%27),tags:!(),timeRestore:!f,title:%27%27,viewMode:edit)
[00:21:39]               │ info Saving page source to: /dev/shm/workspace/parallel/1/kibana/x-pack/test/functional/failure_debug/html/dashboard sync colors should sync colors on dashboard by default.html
[00:21:39]               └- ✖ fail: dashboard sync colors should sync colors on dashboard by default
[00:21:39]               │      retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:39]               │ Wait timed out after 10026ms
[00:21:39]               │     at /dev/shm/workspace/parallel/1/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:21:39]               │     at runMicrotasks (<anonymous>)
[00:21:39]               │     at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:21:39]               │     at onFailure (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:21:39]               │     at retryForSuccess (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:21:39]               │     at Retry.try (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry.ts:32:14)
[00:21:39]               │     at Proxy.clickByCssSelector (/dev/shm/workspace/parallel/1/kibana/test/functional/services/common/find.ts:420:7)
[00:21:39]               │     at TestSubjects.click (/dev/shm/workspace/parallel/1/kibana/test/functional/services/common/test_subjects.ts:109:7)
[00:21:39]               │     at /dev/shm/workspace/parallel/1/kibana/x-pack/test/functional/page_objects/lens_page.ts:114:9
[00:21:39]               │     at runAttempt (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:27:15)
[00:21:39]               │     at retryForSuccess (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:66:21)
[00:21:39]               │     at Retry.try (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry.ts:32:14)
[00:21:39]               │     at Object.configureDimension (/dev/shm/workspace/parallel/1/kibana/x-pack/test/functional/page_objects/lens_page.ts:113:7)
[00:21:39]               │     at Context.<anonymous> (/dev/shm/workspace/parallel/1/kibana/x-pack/test/functional/apps/dashboard/sync_colors.ts:55:7)
[00:21:39]               │     at Object.apply (/dev/shm/workspace/parallel/1/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:21:39]               │   Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
[00:21:39]               │   Wait timed out after 10026ms
[00:21:39]               │       at /dev/shm/workspace/parallel/1/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:21:39]               │       at runMicrotasks (<anonymous>)
[00:21:39]               │       at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:21:39]               │       at onFailure (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:21:39]               │       at retryForSuccess (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:21:39]               │       at Retry.try (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry.ts:32:14)
[00:21:39]               │       at Proxy.clickByCssSelector (/dev/shm/workspace/parallel/1/kibana/test/functional/services/common/find.ts:420:7)
[00:21:39]               │       at TestSubjects.click (/dev/shm/workspace/parallel/1/kibana/test/functional/services/common/test_subjects.ts:109:7)
[00:21:39]               │       at /dev/shm/workspace/parallel/1/kibana/x-pack/test/functional/page_objects/lens_page.ts:114:9
[00:21:39]               │       at runAttempt (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:27:15)
[00:21:39]               │       at retryForSuccess (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:66:21)
[00:21:39]               │       at Retry.try (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry.ts:32:14)
[00:21:39]               │       at Object.configureDimension (test/functional/page_objects/lens_page.ts:113:7)
[00:21:39]               │       at Context.<anonymous> (test/functional/apps/dashboard/sync_colors.ts:55:7)
[00:21:39]               │       at Object.apply (/dev/shm/workspace/parallel/1/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:21:39]               │       at onFailure (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:21:39]               │       at retryForSuccess (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:21:39]               │       at Retry.try (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry.ts:32:14)
[00:21:39]               │       at Object.configureDimension (test/functional/page_objects/lens_page.ts:113:7)
[00:21:39]               │       at Context.<anonymous> (test/functional/apps/dashboard/sync_colors.ts:55:7)
[00:21:39]               │       at Object.apply (/dev/shm/workspace/parallel/1/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:21:39]               │ 
[00:21:39]               │

Stack Trace

Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="lns-layerPanel-0"] [data-test-subj="lnsXY_yDimensionPanel"] [data-test-subj="lns-empty-dimension"])
Wait timed out after 10026ms
    at /dev/shm/workspace/parallel/1/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at onFailure (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at Retry.try (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry.ts:32:14)
    at Proxy.clickByCssSelector (/dev/shm/workspace/parallel/1/kibana/test/functional/services/common/find.ts:420:7)
    at TestSubjects.click (/dev/shm/workspace/parallel/1/kibana/test/functional/services/common/test_subjects.ts:109:7)
    at /dev/shm/workspace/parallel/1/kibana/x-pack/test/functional/page_objects/lens_page.ts:114:9
    at runAttempt (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:27:15)
    at retryForSuccess (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:66:21)
    at Retry.try (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry.ts:32:14)
    at Object.configureDimension (test/functional/page_objects/lens_page.ts:113:7)
    at Context.<anonymous> (test/functional/apps/dashboard/sync_colors.ts:55:7)
    at Object.apply (/dev/shm/workspace/parallel/1/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
    at onFailure (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at Retry.try (/dev/shm/workspace/parallel/1/kibana/test/common/services/retry/retry.ts:32:14)
    at Object.configureDimension (test/functional/page_objects/lens_page.ts:113:7)
    at Context.<anonymous> (test/functional/apps/dashboard/sync_colors.ts:55:7)
    at Object.apply (/dev/shm/workspace/parallel/1/kibana/node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	407.7KB	407.8KB	+103.0B

History

💚 Build #121050 succeeded d8bc3da
💔 Build #120981 failed 789409d
💔 Build #120885 failed 68ad86e
💔 Build #120877 failed bbe79df
💚 Build #120494 succeeded 9801524

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

elasticmachine · 2021-04-20T18:28:59Z

Pinging @elastic/kibana-app (Team:KibanaApp)

…c#97434) Co-authored-by: Tim Roes <mail@timroes.de>

…c#97434) Co-authored-by: Tim Roes <mail@timroes.de> # Conflicts: # src/plugins/discover/public/application/angular/discover_state.ts

#97706) Co-authored-by: Tim Roes <mail@timroes.de> Co-authored-by: Tim Roes <mail@timroes.de>

…97434) (#97711) * [Discover] Fix wrong sort order with empty sort URL parameter (#97434) Co-authored-by: Tim Roes <mail@timroes.de> # Conflicts: # src/plugins/discover/public/application/angular/discover_state.ts * Update _shared_links.ts

kertal self-assigned this Apr 19, 2021

kertal added the Feature:Discover Discover Application label Apr 19, 2021

Fix initial state sort handling

9801524

kertal force-pushed the kertal-pr-2021-04-19-discover-fix-initial-state-sort-handling branch from abba7f4 to 9801524 Compare April 19, 2021 10:34

kertal changed the title ~~[Discover] Fix sort handling~~ [Discover] Fix initial handling of appState sort parameter Apr 19, 2021

kibanamachine and others added 2 commits April 20, 2021 04:56

Merge branch 'master' into kertal-pr-2021-04-19-discover-fix-initial-…

d52d77d

…state-sort-handling

Add functional test

bbe79df

kertal added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:fix v7.13.0 v8.0.0 v7.12.1 labels Apr 20, 2021

Merge branch 'master' into kertal-pr-2021-04-19-discover-fix-initial-…

68ad86e

…state-sort-handling

kertal added 3 commits April 20, 2021 15:40

Merge remote-tracking branch 'upstream/master' into kertal-pr-2021-04…

7cbf43c

…-19-discover-fix-initial-state-sort-handling

Merge branch 'kertal-pr-2021-04-19-discover-fix-initial-state-sort-ha…

adc8666

…ndling' of github.com:kertal/kibana into kertal-pr-2021-04-19-discover-fix-initial-state-sort-handling

Fix functional test

789409d

kertal changed the title ~~[Discover] Fix initial handling of appState sort parameter~~ [Discover] Fix wrong sort order with empty sort URL parameter Apr 20, 2021

timroes reviewed Apr 20, 2021

View reviewed changes

src/plugins/discover/public/application/angular/discover_state.ts Outdated Show resolved Hide resolved

Fix functional test

d8bc3da

timroes approved these changes Apr 20, 2021

View reviewed changes

Update src/plugins/discover/public/application/angular/discover_state.ts

828d75d

Co-authored-by: Tim Roes <mail@timroes.de>

kertal marked this pull request as ready for review April 20, 2021 18:28

kertal requested a review from a team April 20, 2021 18:28

kertal merged commit 597325c into elastic:master Apr 20, 2021

kertal added a commit to kertal/kibana that referenced this pull request Apr 20, 2021

[Discover] Fix wrong sort order with empty sort URL parameter (elasti…

c208fb2

…c#97434) Co-authored-by: Tim Roes <mail@timroes.de>

kertal mentioned this pull request Apr 20, 2021

[7.x] [Discover] Fix wrong sort order with empty sort URL parameter (#97434) #97706

Merged

kertal mentioned this pull request Apr 20, 2021

[7.12] [Discover] Fix wrong sort order with empty sort URL parameter (#97434) #97711

Merged

kertal added a commit that referenced this pull request Apr 20, 2021

[Discover] Fix wrong sort order with empty sort URL parameter (#97434) (

79190d3

#97706) Co-authored-by: Tim Roes <mail@timroes.de> Co-authored-by: Tim Roes <mail@timroes.de>

kertal added v7.12.2 and removed v7.12.1 labels Apr 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] Fix wrong sort order with empty sort URL parameter #97434

[Discover] Fix wrong sort order with empty sort URL parameter #97434

kertal commented Apr 19, 2021 •

edited

Loading

kertal commented Apr 20, 2021

kertal commented Apr 20, 2021

timroes left a comment •

edited

Loading

kibanamachine commented Apr 20, 2021

Standard Out

Stack Trace

elasticmachine commented Apr 20, 2021

[Discover] Fix wrong sort order with empty sort URL parameter #97434

[Discover] Fix wrong sort order with empty sort URL parameter #97434

Conversation

kertal commented Apr 19, 2021 • edited Loading

Summary

From 7.7.0 to 7.11.0

7.12

The issue with invalid sorting behavior as a result of 7.12 changes

Testing

Checklist

kertal commented Apr 20, 2021

kertal commented Apr 20, 2021

timroes left a comment • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Apr 20, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Async chunks

History

elasticmachine commented Apr 20, 2021

kertal commented Apr 19, 2021 •

edited

Loading

timroes left a comment •

edited

Loading