[Discover] Change default sort handling for index patterns without timefield

[kertal]

Summary

Before this PR, when using index patterns without a timefield, the sorting by _score was added to the state if there was no sort set by user / url. Before multi sort was implemented, this sorting was replaced when switching to an indexpattern with timefield, or when the user adds a sort by field. With the new multisort, switching to another index pattern or selecting another sort field, adds the new field in the sort array in state ( so sorting by _score becomes sorting by _score, newTimefield ).

Solution

The default sort is only used in UI and before sending the Request to ES. It's not added to state. This is only done after user interaction.

You can test this by using our demo data, adding a new index pattern kibana_sample* without a timefield.

Fixes #49050

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[Bargs]

Hmm I see a couple disadvantages to taking _score out of the app state:

• If the user adds the _score field as a column in the doc table, the UI won't show them that _score is being sorted on.
• _score and timestamp are both defaults, but they work differently now. If I'm on a non-timebased index pattern and I manually sort on a field, then I switch to a timebased index pattern, I get a multi sort with the first field plus the time field.

Switching index patterns should probably never modify a sort the the user has explicitly added themselves. And I think the UI should always be able to reflect what field is being sorted on even if it is a default.

[kertal]

good points, thx, I will think how to further improve this solution!

[Bargs]

I think this line can be removed since getSort.array no longer takes a defaultOrder
https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js#L523

Otherwise looks good! Nice work 👍

[kertal]

@elasticmachine merge upstream

[kertal]

Thx @Bargs , i've removed the line.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 03250aa

History

• 💚 Build #22079 succeeded 416c38b
• 💚 Build #21480 succeeded 736a88c
• 💔 Build #21464 failed c668ff6
• 💔 Build #21315 failed 953bb96
• 💚 Build #20102 succeeded 33505e1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream