Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] The Observability Getting Started page infinitely redirects, breaking browser's back button #95083

Merged
merged 2 commits into from
Mar 23, 2021
Merged

[APM] The Observability Getting Started page infinitely redirects, breaking browser's back button #95083

merged 2 commits into from
Mar 23, 2021

Conversation

cauemarcondes
Copy link
Contributor

closes #94932

obs.back.button.1.mov
obs.back.button.2.mov

@cauemarcondes cauemarcondes requested a review from sorenlouv March 22, 2021 17:15
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 178.1KB 178.1KB +6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 23, 2021
@cauemarcondes cauemarcondes merged commit 134959d into elastic:master Mar 23, 2021
@cauemarcondes cauemarcondes deleted the obs-back-button branch March 23, 2021 16:42
@kibanamachine kibanamachine mentioned this pull request Mar 23, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 23, 2021
@cauemarcondes @kibanamachine
[APM] The Observability Getting Started page infinitely redirects, br…
55330f8 
…eaking browser's back button (elastic#95083)

* fixing browser back button

* fixing test
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #95196

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 23, 2021
@kibanamachine @cauemarcondes
[APM] The Observability Getting Started page infinitely redirects, br…
fd958d5 
…eaking browser's back button (#95083) (#95196)

* fixing browser back button

* fixing test

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
@timroes timroes added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Apr 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Observability Landing - Milestone 1 release_note:fix Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] The Observability Getting Started page infinitely redirects, breaking browser's back button
5 participants
@cauemarcondes @kibanamachine @elasticmachine @sorenlouv @timroes