[APM] The Observability Getting Started page infinitely redirects, br…

…eaking browser's back button (#95083) (#95196) * fixing browser back button * fixing test Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
elastic · Mar 23, 2021 · fd958d5 · fd958d5
1 parent 82b6bcc
commit fd958d5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/x-pack/plugins/observability/public/pages/home/index.test.tsx b/x-pack/plugins/observability/public/pages/home/index.test.tsx
@@ -14,7 +14,7 @@ import { HomePage } from './';
 const mockHistoryPush = jest.fn();
 jest.mock('react-router-dom', () => ({
   useHistory: () => ({
-    push: mockHistoryPush,
+    replace: mockHistoryPush,
   }),
 }));
 

diff --git a/x-pack/plugins/observability/public/pages/home/index.tsx b/x-pack/plugins/observability/public/pages/home/index.tsx
@@ -16,9 +16,9 @@ export function HomePage() {
 
   useEffect(() => {
     if (hasAnyData === true) {
-      history.push({ pathname: '/overview' });
+      history.replace({ pathname: '/overview' });
     } else if (hasAnyData === false && isAllRequestsComplete === true) {
-      history.push({ pathname: '/landing' });
+      history.replace({ pathname: '/landing' });
     }
   }, [hasAnyData, isAllRequestsComplete, history]);