[4.7] Speed up rendering of large docs in doc table (#9014) #9150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in 2014 a utility was added to insert <wbr> (word break opportunity) tags into doc table fields to improve their display in the browser. This utility looped over every character in _source when it was selected as a column in the doc table, which it was be default. That really started to slow things down when displaying large docs. We can maintain similar word breaking without adding <wbr> tags by adding some css styles that do essentially the same job. word-break: break-word gives us the best formatting but it's not a part of the standard yet (see link below) so I provided an almost-as-good fallback with break-all. https://bugs.chromium.org/p/chromium/issues/detail?id=492202#c21 Fixes elastic#6328 Related elastic#1993
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #9014
Back in 2014 a utility was added to insert (word break opportunity)
tags into doc table fields to improve their display in the browser. This
utility looped over every character in _source when it was selected as a
column in the doc table, which it was be default. That really started to
slow things down when displaying large docs. We can maintain similar word
breaking without adding tags by adding some css styles that
do essentially the same job. word-break: break-word gives us the best
formatting but it's not a part of the standard yet (see link below) so I
provided an almost-as-good fallback with break-all.
https://bugs.chromium.org/p/chromium/issues/detail?id=492202#c21
Fixes #6328
Related #1993