Speed up rendering of large docs in doc table #9014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in 2014 a utility was added to insert <wbr> (word break opportunity) tags into doc table fields to improve their display in the browser. This utility looped over every character in _source when it was selected as a column in the doc table, which it was be default. That really started to slow things down when displaying large docs. I compared how the browser renders things with and without the <wbr>'s and there's almost no difference, certainly nothing as dramatic as shown in the linked PR which added this word breaking functionality. Perhaps browsers have improved in the last two years, or perhaps something changed in our CSS. Since we're getting no or negligible value from this utility and it makes Discover impossible to use with large docs, I simply removed it. Fixes elastic#6328 Related elastic#1993
|
I have examined the change in various scenarios and saw some unfortunate column sizing without the
Maybe this is a suitable replacement with better performance? |
|
Great idea, I think break-word is exactly what we should use. Based on my tests I suspected it was already being used but I guess I didn't hit the right edge case. I'll update the PR. |
To maintain similar word breaking without adding <wbr> tags I've added some css styles that do essentially the same job. word-break: break-word gives us the best formatting but it's not a part of the standard yet (see link below) so I provided an almost-as-good fallback with break-all. https://bugs.chromium.org/p/chromium/issues/detail?id=492202#c21
|
PR updated and ready for re-testing. I had to provide a fallback rule as well because break-word is not yet a part of the CSS standard. |
lukasolson
approved these changes
Nov 11, 2016
Bargs
pushed a commit
that referenced
this pull request
Nov 15, 2016
Backports PR #9014 **Commit 1:** Speed up rendering of large docs in doc table Back in 2014 a utility was added to insert <wbr> (word break opportunity) tags into doc table fields to improve their display in the browser. This utility looped over every character in _source when it was selected as a column in the doc table, which it was be default. That really started to slow things down when displaying large docs. I compared how the browser renders things with and without the <wbr>'s and there's almost no difference, certainly nothing as dramatic as shown in the linked PR which added this word breaking functionality. Perhaps browsers have improved in the last two years, or perhaps something changed in our CSS. Since we're getting no or negligible value from this utility and it makes Discover impossible to use with large docs, I simply removed it. Fixes #6328 Related #1993 * Original sha: fc443bb * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-11-09T00:11:45Z **Commit 2:** Improve word breaking in doc table To maintain similar word breaking without adding <wbr> tags I've added some css styles that do essentially the same job. word-break: break-word gives us the best formatting but it's not a part of the standard yet (see link below) so I provided an almost-as-good fallback with break-all. https://bugs.chromium.org/p/chromium/issues/detail?id=492202#c21 * Original sha: ac38524 * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-11-10T23:01:30Z
Bargs
pushed a commit
that referenced
this pull request
Nov 15, 2016
Backports PR #9014 **Commit 1:** Speed up rendering of large docs in doc table Back in 2014 a utility was added to insert <wbr> (word break opportunity) tags into doc table fields to improve their display in the browser. This utility looped over every character in _source when it was selected as a column in the doc table, which it was be default. That really started to slow things down when displaying large docs. I compared how the browser renders things with and without the <wbr>'s and there's almost no difference, certainly nothing as dramatic as shown in the linked PR which added this word breaking functionality. Perhaps browsers have improved in the last two years, or perhaps something changed in our CSS. Since we're getting no or negligible value from this utility and it makes Discover impossible to use with large docs, I simply removed it. Fixes #6328 Related #1993 * Original sha: fc443bb * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-11-09T00:11:45Z **Commit 2:** Improve word breaking in doc table To maintain similar word breaking without adding <wbr> tags I've added some css styles that do essentially the same job. word-break: break-word gives us the best formatting but it's not a part of the standard yet (see link below) so I provided an almost-as-good fallback with break-all. https://bugs.chromium.org/p/chromium/issues/detail?id=492202#c21 * Original sha: ac38524 * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-11-10T23:01:30Z
elastic-jasper
added a commit
that referenced
this pull request
Nov 18, 2016
Backports PR #9014 **Commit 1:** Speed up rendering of large docs in doc table Back in 2014 a utility was added to insert <wbr> (word break opportunity) tags into doc table fields to improve their display in the browser. This utility looped over every character in _source when it was selected as a column in the doc table, which it was be default. That really started to slow things down when displaying large docs. I compared how the browser renders things with and without the <wbr>'s and there's almost no difference, certainly nothing as dramatic as shown in the linked PR which added this word breaking functionality. Perhaps browsers have improved in the last two years, or perhaps something changed in our CSS. Since we're getting no or negligible value from this utility and it makes Discover impossible to use with large docs, I simply removed it. Fixes #6328 Related #1993 * Original sha: fc443bb * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-11-09T00:11:45Z **Commit 2:** Improve word breaking in doc table To maintain similar word breaking without adding <wbr> tags I've added some css styles that do essentially the same job. word-break: break-word gives us the best formatting but it's not a part of the standard yet (see link below) so I provided an almost-as-good fallback with break-all. https://bugs.chromium.org/p/chromium/issues/detail?id=492202#c21 * Original sha: ac38524 * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-11-10T23:01:30Z
Bargs
pushed a commit
to Bargs/kibana
that referenced
this pull request
Nov 18, 2016
Back in 2014 a utility was added to insert <wbr> (word break opportunity) tags into doc table fields to improve their display in the browser. This utility looped over every character in _source when it was selected as a column in the doc table, which it was be default. That really started to slow things down when displaying large docs. We can maintain similar word breaking without adding <wbr> tags by adding some css styles that do essentially the same job. word-break: break-word gives us the best formatting but it's not a part of the standard yet (see link below) so I provided an almost-as-good fallback with break-all. https://bugs.chromium.org/p/chromium/issues/detail?id=492202#c21 Fixes elastic#6328 Related elastic#1993
epixa
pushed a commit
that referenced
this pull request
Nov 21, 2016
Back in 2014 a utility was added to insert <wbr> (word break opportunity) tags into doc table fields to improve their display in the browser. This utility looped over every character in _source when it was selected as a column in the doc table, which it was be default. That really started to slow things down when displaying large docs. We can maintain similar word breaking without adding <wbr> tags by adding some css styles that do essentially the same job. word-break: break-word gives us the best formatting but it's not a part of the standard yet (see link below) so I provided an almost-as-good fallback with break-all. https://bugs.chromium.org/p/chromium/issues/detail?id=492202#c21 Fixes #6328 Related #1993
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#9014 **Commit 1:** Speed up rendering of large docs in doc table Back in 2014 a utility was added to insert <wbr> (word break opportunity) tags into doc table fields to improve their display in the browser. This utility looped over every character in _source when it was selected as a column in the doc table, which it was be default. That really started to slow things down when displaying large docs. I compared how the browser renders things with and without the <wbr>'s and there's almost no difference, certainly nothing as dramatic as shown in the linked PR which added this word breaking functionality. Perhaps browsers have improved in the last two years, or perhaps something changed in our CSS. Since we're getting no or negligible value from this utility and it makes Discover impossible to use with large docs, I simply removed it. Fixes elastic#6328 Related elastic#1993 * Original sha: fc443bb * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-11-09T00:11:45Z **Commit 2:** Improve word breaking in doc table To maintain similar word breaking without adding <wbr> tags I've added some css styles that do essentially the same job. word-break: break-word gives us the best formatting but it's not a part of the standard yet (see link below) so I provided an almost-as-good fallback with break-all. https://bugs.chromium.org/p/chromium/issues/detail?id=492202#c21 * Original sha: ac38524 * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-11-10T23:01:30Z Former-commit-id: 379abee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in 2014 a utility was added to insert (word break opportunity)
tags into doc table fields to improve their display in the browser. This
utility looped over every character in _source when it was selected as a
column in the doc table, which it was be default. That really started to
slow things down when displaying large docs. I compared how the browser
renders things with and without the 's and there's almost no
difference, certainly nothing as dramatic as shown in the linked PR
which added this word breaking functionality. Perhaps browsers have
improved in the last two years, or perhaps something changed in our CSS.
Since we're getting no or negligible value from this utility and it
makes Discover impossible to use with large docs, I simply removed it.
Fixes #6328
Related #1993