Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index templates] Keep configuration of data stream when editing #87666

Merged

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Jan 7, 2021

Fixes #87293

This PR fixes a bug in index template UI where we didn't keep the configuration of the data_stream object when editing an composable index template.

Step to reproduce

  1. Create a template with a hidden configuration for the data stream
PUT _index_template/test
{
  "template": {},
  "index_patterns": [
    "somepattern*"
  ],
  "data_stream": {
    "hidden": true   
  }
}
  1. Navigate to the index template UI and edit this "test" template
  2. Go to the review tab. The data_stream configuration should appear under the "Request" tab
  3. Save the template
  4. In console, fetching the template should still return the previous data stream config
GET _index_template/test

@sebelga sebelga requested a review from a team as a code owner January 7, 2021 16:13
@sebelga
Copy link
Contributor Author

sebelga commented Jan 7, 2021

Note that I haven't modified the "Logistics" form to be able to set the hidden parameter for the data stream. If we think it is important to support it in the UI we can do it in a separate PR (probably for the 7.12 release). WDYT @alisonelizabeth ?

@sebelga sebelga added bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 v7.12 v8.0.0 labels Jan 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@sebelga sebelga added v7.12.0 and removed v7.12 labels Jan 7, 2021
@alisonelizabeth alisonelizabeth added the release_note:skip Skip the PR/issue when compiling release notes label Jan 7, 2021
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. Verified locally. Thanks for fixing this @sebelga!

@alisonelizabeth
Copy link
Contributor

Note that I haven't modified the "Logistics" form to be able to set the hidden parameter for the data stream. If we think it is important to support it in the UI we can do it in a separate PR (probably for the 7.12 release). WDYT @alisonelizabeth ?

👍 Per #83709, we do not need to surface in the UI:

Note: The hidden data streams feature is targeted at consumers in the Stack (elastic/elasticsearch#63889), so we won't update the Index Templates wizard with the option for defining an index template that will generate a hidden data stream.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 1.5MB 1.5MB +326.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sebelga sebelga merged commit 6d6a805 into elastic:master Jan 7, 2021
@sebelga sebelga deleted the fix/index-template-data-stream-config branch January 7, 2021 21:42
sebelga added a commit to sebelga/kibana that referenced this pull request Jan 7, 2021
…stic#87666)

# Conflicts:
#	x-pack/plugins/index_management/__jest__/client_integration/index_template_wizard/template_edit.test.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Index template] Data stream configuration is removed
4 participants