Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hidden data streams in Index Management #83709

Closed
cjcenizal opened this issue Nov 18, 2020 · 1 comment · Fixed by #85028
Closed

Support hidden data streams in Index Management #83709

cjcenizal opened this issue Nov 18, 2020 · 1 comment · Fixed by #85028
Assignees
Labels
enhancement New value added to drive a business result Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Nov 18, 2020

elastic/elasticsearch#63987 added the ability to specify that data streams should be hidden, shipping with 7.11. We need to update the data streams tab of Index Management to support retrieval and display of hidden data streams similarly to how hidden indices are retrieved and displayed in the indices tab.

Note: The hidden data streams feature is targeted at consumers in the Stack (elastic/elasticsearch#63889), so we won't update the Index Templates wizard with the option for defining an index template that will generate a hidden data stream.

Changes

API changes

We need to update the data streams API to retrieve all data streams including hidden ones: GET _data_stream?expand_wildcards=hidden,all.

UI changes

We need to add a toggle to the UI to allow users to reveal hidden data streams.

Also, we need to adjust the logic that renders the empty prompt. Currently, the table will be hidden and an empty prompt is rendered if the API response contains zero data streams. After we change the API to return both hidden and non-hidden data streams, the response will always contain data streams. So we'll want to update the rendering logic to render the empty prompt if there are zero non-hidden data streams and if the "Show hidden" toggle is disabled. We'll also want to ensure this toggle is always rendered, so users can enable it.

Cross-linking changes

We added logic in #66715 and #67940 to allow the user to click into a data stream's indices. Doing so will navigate from the data streams tab to the indices tab, set a filter to show only that data stream's indices, and enable the "Show hidden" toggle if the indices are known to be hidden.

We need to implement similar functionality for when the user clicks into an index's data stream. Currently, this will navigate from the indices tab to the data streams tab and set a filter to show only that index's data stream. We need to add logic for enabling the "Show hidden" toggle if that data stream is known to be hidden.

Testing

These requests will generate a hidden data stream called test.

PUT _index_template/test
{
  "template": {},
  "index_patterns": [
    "test"
  ],
  "data_stream": {
    "hidden": true   
  }
}

POST test/_doc
{
  "@timestamp": "2020-01-27"
}

# Retrieve the hidden data streams
GET _data_stream?expand_wildcards=hidden,all
@cjcenizal cjcenizal added enhancement New value added to drive a business result Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Nov 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants