Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILM] Fix hot phase serialization #87213

Merged
merged 10 commits into from
Jan 7, 2021
Merged

[ILM] Fix hot phase serialization #87213

merged 10 commits into from
Jan 7, 2021

Conversation

alisonelizabeth
Copy link
Contributor

Fixes #87208

This looks like it might be a regression of #85579, which is part of the 7.11 work, so skipping release note.

How to test:

  1. Go to ILM and create a policy.
  2. Open advanced settings for the hot phase and enable the force merge action. Specify number of segments and enable the "Compress stored fields" toggle.
  3. Enable the "readonly" toggle for the hot phase.
  4. Verify the JSON preview and save policy.
  5. Reopen policy and verify settings saved correctly.
  6. Verify the same behavior in steps 1-5, but with "Use recommended defaults" disabled.
  7. Verify behavior is as expected when "Enable rollover" is disabled. (From what I can tell, all fields should be hidden except "Index priority").

@alisonelizabeth alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 labels Jan 4, 2021
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner January 4, 2021 19:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@jloleysens
Copy link
Contributor

@elasticmachine merge upstream

@jloleysens jloleysens closed this Jan 6, 2021
@kibanamachine
Copy link
Contributor

ignoring request to update branch, pull request is closed

@jloleysens jloleysens reopened this Jan 6, 2021
@jloleysens
Copy link
Contributor

@elasticmachine merge upstream

jloleysens and others added 5 commits January 6, 2021 11:36
@jloleysens
refactor: rename _meta.hot.useRollover to _meta.hot.customRollover.en…
637150c 
…abled for clarity. updated all references, added commetns and updated serialization logic to handle all cases
@jloleysens
add comment
9828fed
@alisonelizabeth
Merge pull request #3 from jloleysens/jl/bugfix/ilm_hot_phase_seriali…
806ad14 
…zation

[JL] Fix hot phase serialization
@alisonelizabeth
Merge branch 'master' of github.com:elastic/kibana into bugfix/ilm_ho…
206016a 
…t_phase_serialization
@alisonelizabeth
fix edge cases
bfcdfb4
@alisonelizabeth
Copy link
Contributor Author

@jloleysens would you mind taking another look at this when you have time? I incorporated your changes from alisonelizabeth#3. I also addressed the bugs I mentioned in alisonelizabeth#3 (comment) via bfcdfb4. Thanks!

@alisonelizabeth alisonelizabeth mentioned this pull request Jan 6, 2021
Closed
@jloleysens
Copy link
Contributor

@elasticmachine merge upstream

jloleysens
jloleysens approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and the changes look good to me! Great work @alisonelizabeth 🍻

I think it would be really awesome to add a test case for the first scenario you outlined here: alisonelizabeth#3 (comment). To ensure that hidden rollover fields do not block form submission - not blocking on this though!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 249.9KB 250.2KB +358.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth merged commit a22f285 into elastic:master Jan 7, 2021
@alisonelizabeth alisonelizabeth deleted the bugfix/ilm_hot_phase_serialization branch January 7, 2021 19:08
This was referenced Jan 7, 2021
Merged
Merged
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Jan 7, 2021
@alisonelizabeth
[ILM] Fix hot phase serialization (elastic#87213)
8719565
@alisonelizabeth alisonelizabeth mentioned this pull request Jan 7, 2021
Closed
alisonelizabeth added a commit that referenced this pull request Jan 7, 2021
@alisonelizabeth
[ILM] Fix hot phase serialization (#87213) (#87707)
c006bc3
alisonelizabeth added a commit that referenced this pull request Jan 7, 2021
@alisonelizabeth
[ILM] Fix hot phase serialization (#87213) (#87706)
2df1745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ILM] Force merge and readonly not configurable in hot phase
4 participants
@alisonelizabeth @elasticmachine @jloleysens @kibanamachine