Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILM] Rollover field redesign #85579

Merged
merged 14 commits into from
Dec 14, 2020
Merged

[ILM] Rollover field redesign #85579

merged 14 commits into from
Dec 14, 2020

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Dec 10, 2020 •
edited
Loading

Summary

Re-opening work done here: #84198

How to test

  1. Start Kibana on basic license (yarn start)
  2. Create a new ILM policy
  3. Give it a name
  4. Open advanced in the hot phase
  5. Opt out of default rollover configuration
  6. Customize rollover
  7. Save
  8. View the policy that was just created

Screenshots

Screenshot 2020-12-10 at 12 16 03

Screenshot 2020-12-10 at 12 16 08

Screenshot 2020-12-10 at 12 16 15

Gif

rollover-in-advanced

New copy!

Per the screenshots

  1. Rollover field description text
  2. Tooltip text

Additional notes

  • includes a fix for rollover serialisation (will open separate PR to not block on design and copy review here)

Checklist

Delete any items that are not applicable to this PR.

@jloleysens jloleysens added Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 10, 2020
@jloleysens jloleysens requested a review from a team as a code owner December 10, 2020 14:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@lockewritesdocs lockewritesdocs self-requested a review December 10, 2020 15:41
@yuliacech yuliacech self-assigned this Dec 10, 2020
@yuliacech
Copy link
Contributor

@elasticmachine merge upstream

mdefazio
mdefazio approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have some slight tweaks to this for the next version, but I think this is good for this next step.

yuliacech
yuliacech approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @jloleysens, thanks a lot for working on this ! tested locally and changes LGTM :)

lockewritesdocs
lockewritesdocs approved these changes Dec 14, 2020
View reviewed changes
Copy link

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Made a few suggestions that I think help to clarify the tooltip and rollover descriptions.

yuliacech and others added 3 commits December 14, 2020 18:00
@yuliacech
Update x-pack/plugins/index_lifecycle_management/public/application/s…
da1d928 
…ections/edit_policy/components/phases/hot_phase/hot_phase.tsx

Co-authored-by: Adam Locke <adam.locke@elastic.co>
@yuliacech
Update x-pack/plugins/index_lifecycle_management/public/application/s…
5d1ca35 
…ections/edit_policy/components/phases/hot_phase/hot_phase.tsx

Co-authored-by: Adam Locke <adam.locke@elastic.co>
@yuliacech
Update x-pack/plugins/index_lifecycle_management/public/application/s…
03594b5 
…ections/edit_policy/components/phases/hot_phase/hot_phase.tsx

Co-authored-by: Adam Locke <adam.locke@elastic.co>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexLifecycleManagement 140 141 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 248.2KB 249.7KB +1.5KB

Distributable file count

id before after diff
default 47130 47890 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexLifecycleManagement 77.3KB 77.5KB +140.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yuliacech yuliacech merged commit b8ab3fd into elastic:master Dec 14, 2020
yuliacech added a commit that referenced this pull request Dec 14, 2020
@jloleysens @yuliacech @kibanamachine
[ILM] Rollover field redesign (#85579)
286f464 
* implement form-level support for using default rollover action

* slight update to copy

* added use default rollover switch and tooltips for detailed copy

* fix legacy integration tests and do not unmount rollover field!!

* remove unused import

* fix client integration tests

* updated form to use new isUsingRollover check

* fix serialization of rollover

* Update x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx

Co-authored-by: Adam Locke <adam.locke@elastic.co>

* Update x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx

Co-authored-by: Adam Locke <adam.locke@elastic.co>

* Update x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx

Co-authored-by: Adam Locke <adam.locke@elastic.co>

Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Adam Locke <adam.locke@elastic.co>
@yuliacech yuliacech mentioned this pull request Dec 14, 2020
Merged
yuliacech added a commit that referenced this pull request Dec 14, 2020
@yuliacech @jloleysens @kibanamachine
[ILM] Rollover field redesign (#85579) (#85851)
0c43626 
* implement form-level support for using default rollover action

* slight update to copy

* added use default rollover switch and tooltips for detailed copy

* fix legacy integration tests and do not unmount rollover field!!

* remove unused import

* fix client integration tests

* updated form to use new isUsingRollover check

* fix serialization of rollover

* Update x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx

Co-authored-by: Adam Locke <adam.locke@elastic.co>

* Update x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx

Co-authored-by: Adam Locke <adam.locke@elastic.co>

* Update x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx

Co-authored-by: Adam Locke <adam.locke@elastic.co>

Co-authored-by: Yulia Čech <6585477+yuliacech@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Adam Locke <adam.locke@elastic.co>

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Adam Locke <adam.locke@elastic.co>
This was referenced Jan 4, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdefazio mdefazio mdefazio approved these changes

@yuliacech yuliacech yuliacech approved these changes

@lockewritesdocs lockewritesdocs lockewritesdocs approved these changes

Assignees

@yuliacech yuliacech

Labels
Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jloleysens @elasticmachine @yuliacech @kibanamachine @mdefazio @lockewritesdocs