Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New events resolver #82170

Merged
merged 41 commits into from
Nov 9, 2020
Merged
Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
6407b75
Added Test for event.library
IgorGuz2000 Oct 15, 2020
981618a
renamed data directry and gzip data file
IgorGuz2000 Oct 16, 2020
63eb262
rename expectedData file
IgorGuz2000 Oct 16, 2020
6ed753a
Merge branch 'master' into New_events_resolver
kibanamachine Oct 19, 2020
00cc83b
Merge remote-tracking branch 'upstream/master' into New_events_resolver
IgorGuz2000 Oct 19, 2020
4382daf
Changes per Charlie request
IgorGuz2000 Oct 19, 2020
332646d
Merge remote-tracking branch 'origin/New_events_resolver' into New_ev…
IgorGuz2000 Oct 19, 2020
9189098
Merge remote-tracking branch 'upstream/master' into New_events_resolver
IgorGuz2000 Oct 22, 2020
ab8604b
Changes for the enable_APM-ci branch
IgorGuz2000 Oct 26, 2020
1492602
Merge branch 'master' into New_events_resolver
kibanamachine Oct 26, 2020
920b5fd
Update resolver.ts
IgorGuz2000 Oct 28, 2020
b752c15
Added comment per Charlie request
IgorGuz2000 Oct 28, 2020
4cbb232
Update resolver.ts
IgorGuz2000 Oct 28, 2020
d7b25a1
Merge remote-tracking branch 'origin/New_events_resolver' into New_ev…
IgorGuz2000 Oct 28, 2020
383dec9
Merge remote-tracking branch 'upstream/master' into New_events_resolver
IgorGuz2000 Oct 28, 2020
e514fce
Merge remote-tracking branch 'upstream/master' into New_events_resolver
IgorGuz2000 Oct 29, 2020
4a5982d
Added Alert Test for Resolver and fix for the APM enabled Run fail
IgorGuz2000 Oct 30, 2020
dcdbe46
Added Alert Test for Resolver and fix for the APM enabled Run fail
IgorGuz2000 Oct 30, 2020
48fee21
removed commented out code
IgorGuz2000 Oct 30, 2020
1a57a7f
Fixing CI fail
IgorGuz2000 Oct 30, 2020
dc62a88
Fixing CI fail
IgorGuz2000 Oct 30, 2020
efdf5cd
Removed Alert Resolver test
IgorGuz2000 Oct 31, 2020
3641439
Merge branch 'master' into New_events_resolver
kibanamachine Oct 31, 2020
b2b9f17
Merge remote-tracking branch 'upstream/master' into New_events_resolver
IgorGuz2000 Nov 1, 2020
da021fc
Merge branch 'master' into New_events_resolver
kibanamachine Nov 2, 2020
4c36f2a
aAdding Alert test back
IgorGuz2000 Nov 3, 2020
d0c0f3c
Merge remote-tracking branch 'origin/New_events_resolver' into New_ev…
IgorGuz2000 Nov 3, 2020
3f9b2b3
Adding Alert test back
IgorGuz2000 Nov 3, 2020
033742a
Merge remote-tracking branch 'upstream/master' into New_events_resolver
IgorGuz2000 Nov 3, 2020
be0bea0
Adding Alert test back
IgorGuz2000 Nov 3, 2020
13fc566
Adding info log for debuging
IgorGuz2000 Nov 3, 2020
0fac8f5
Adding info log for debuging
IgorGuz2000 Nov 3, 2020
89731a3
Adding info log for debuging
IgorGuz2000 Nov 3, 2020
8e661f6
Adding info log for debuging
IgorGuz2000 Nov 4, 2020
17e3cfe
Adding info log for debuging
IgorGuz2000 Nov 4, 2020
57f56c5
Adding info log for debuging
IgorGuz2000 Nov 4, 2020
91a640d
adding one more verification for Data
IgorGuz2000 Nov 4, 2020
a6ea8d3
Merge branch 'master' into New_events_resolver
kibanamachine Nov 4, 2020
6810449
Merge branch 'master' into New_events_resolver
kibanamachine Nov 8, 2020
e594ffd
stripedd Data file
IgorGuz2000 Nov 9, 2020
5918b80
Merge remote-tracking branch 'origin/New_events_resolver' into New_ev…
IgorGuz2000 Nov 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file not shown.
23 changes: 23 additions & 0 deletions x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,29 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
}
await pageObjects.hosts.runNodeEvents(expectedLibraryData);
});

it('Check Related Events for event.alert Node', async () => {
await esArchiver.load('empty_kibana');
await esArchiver.load('endpoint/resolver_tree/alert_events', { useCreate: true });
await queryBar.setQuery('');
await queryBar.submitQuery();
const expectedAlertData = [
'1 library',
'157 file',
'520 registry',
'3 file',
'5 library',
'5 library',
];
await pageObjects.hosts.navigateToEventsPanel();
await pageObjects.hosts.executeQueryAndOpenResolver('event.dataset : endpoint.alerts');
await (await testSubjects.find('resolver:graph-controls:zoom-out')).click();
await browser.setWindowSize(2100, 1500);
for (let i = 0; i < 2; i++) {
await (await testSubjects.find('resolver:graph-controls:east-button')).click();
}
await pageObjects.hosts.runNodeEvents(expectedAlertData);
});
});
});
}
1 change: 0 additions & 1 deletion x-pack/test/security_solution_endpoint/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
['securitySolutionManagement']: {
pathname: '/app/security/administration',
},
...xpackFunctionalConfig.get('apps'),
['security']: {
pathname: '/app/security',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ export function SecurityHostsPageProvider({ getService, getPageObjects }: FtrPro
for (let i = 0; i < NodeSubmenuItems.length; i++) {
await (await testSubjects.findAll('resolver:map:node-submenu-item'))[i].click();
const Events = await testSubjects.findAll('resolver:map:node-submenu-item');
// this sleep is for the AMP enabled run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here, can you change it to APM in a subsequent PR please

await pageObjects.common.sleep(300);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much does this sleep add to the duration of every test? Is there a way you can convert this to a wait?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to do the wait and different ways nothing works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it just adds 2 sec per test only

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support a Sleep if we need the tests passing and to unblock the build. Always good to question it and follow up more if we can improve it

const EventName = await Events[i]._webElement.getText();
const LinkText = await testSubjects.find('resolver:breadcrumbs:last');
const linkText = await LinkText._webElement.getText();
Expand Down