-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New events resolver #82170
New events resolver #82170
Changes from all commits
6407b75
981618a
63eb262
6ed753a
00cc83b
4382daf
332646d
9189098
ab8604b
1492602
920b5fd
b752c15
4cbb232
d7b25a1
383dec9
e514fce
4a5982d
dcdbe46
48fee21
1a57a7f
dc62a88
efdf5cd
3641439
b2b9f17
da021fc
4c36f2a
d0c0f3c
3f9b2b3
033742a
be0bea0
13fc566
0fac8f5
89731a3
8e661f6
17e3cfe
57f56c5
91a640d
a6ea8d3
6810449
e594ffd
5918b80
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -121,6 +121,8 @@ export function SecurityHostsPageProvider({ getService, getPageObjects }: FtrPro | |
for (let i = 0; i < NodeSubmenuItems.length; i++) { | ||
await (await testSubjects.findAll('resolver:map:node-submenu-item'))[i].click(); | ||
const Events = await testSubjects.findAll('resolver:map:node-submenu-item'); | ||
// this sleep is for the AMP enabled run | ||
await pageObjects.common.sleep(300); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How much does this sleep add to the duration of every test? Is there a way you can convert this to a wait? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I try to do the wait and different ways nothing works. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it just adds 2 sec per test only There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I support a Sleep if we need the tests passing and to unblock the build. Always good to question it and follow up more if we can improve it |
||
const EventName = await Events[i]._webElement.getText(); | ||
const LinkText = await testSubjects.find('resolver:breadcrumbs:last'); | ||
const linkText = await LinkText._webElement.getText(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here, can you change it to APM in a subsequent PR please