Removing circular dependency between spaces and security #81891

legrego · 2020-10-28T11:46:05Z

Summary

We've discussed a number of ways to break the circular dependency between security and spaces. A few of those options are outlined in #80496 (comment).

While I think we all agree it isn't the best solution, this PR implements "option 2" as described in the above comment:

Allow the SpacesClient to be augmented via a security wrapper (like we do for saved objects) which can then authorize access to spaces.

I view this as a mid-term solution until we can explore something more holistic that isn't so tightly coupled to Spaces.

In order to make the SpacesClient "wrappable", this PR introduces a new SpacesClientService, which exposes functions to influence the creation of client instances, as well as a factory function to create the scoped spaces clients.

The Security plugin registers a SpacesClient Wrapper during setup, which is responsible for performing authorization checks and audit logging.

Resolves #80496

legrego · 2020-11-09T16:57:50Z

x-pack/plugins/enterprise_search/server/lib/check_access.ts

+    allowedAtSpace = true;
+  }
+
+  if (spaces && attemptSpaceRetrieval) {


note Previously, the implicit run order of the various Capability Switchers guaranteed that Enterprise Search wouldn't overwrite the decision made by the Spaces plugin to disable these features.

The run order of these switchers has changed now that we've changed the dependency between security and spaces, and so Enterprise Search now needs to check for itself whether or not its feature is disabled within the current space.

legrego · 2020-11-09T16:58:25Z

x-pack/plugins/security/server/plugin.ts

      features,
      getCurrentUser: this.authc.getCurrentUser,
    });

+    if (spaces) {


note: need to add tests for this yet.

legrego · 2020-11-09T16:59:02Z

x-pack/plugins/security/server/spaces/legacy_audit_logger.ts

+/**
+ * @deprecated will be removed in 8.0
+ */
+export class LegacySpacesAuditLogger {


note: Renamed in anticipation of introducing an ECS audit logger for spaces

legrego · 2020-11-09T17:00:23Z

x-pack/plugins/security/server/spaces/secure_spaces_client_wrapper.ts

@@ -0,0 +1,207 @@
+/*


note: It's a net-new file, but the logic was extracted from the existing SpacesClient, and so was mostly copy/paste. A review here is still highly beneficial though!

legrego · 2020-11-09T17:50:44Z

x-pack/plugins/spaces/server/routes/api/external/share_to_space.ts

@@ -37,31 +37,6 @@ export function initShareToSpacesApi(deps: ExternalRouteDeps) {
    object: schema.object({ type: schema.string(), id: schema.string() }),
  });

-  externalRouter.get(
-    {
-      path: '/internal/spaces/_share_saved_object_permissions',


note: route has been moved to the security plugin under /internal/security/_share_saved_object_permissions

elasticmachine · 2020-11-09T20:51:25Z

Pinging @elastic/kibana-security (Team:Security)

azasypkin · 2020-11-10T11:18:06Z

ACK: will review today or tomorrow morning at the latest.

cee-chen

Just a few comments (mostly around the tests file) from the Enterprise Search side of things, thank you so much for doing this for us Larry!!

x-pack/plugins/enterprise_search/server/lib/check_access.test.ts

x-pack/plugins/enterprise_search/server/lib/check_access.ts

azasypkin

The approach looks good to me! Haven't tested manually yet, but will do at the next review pass. Left mostly nits and a couple of questions.

azasypkin · 2020-11-11T11:28:22Z

x-pack/plugins/spaces/server/plugin.ts

@@ -58,30 +62,33 @@ export class Plugin {

  private defaultSpaceService?: DefaultSpaceService;

+  private spacesService?: SpacesService;


nit: it seems we can just create this service in constructor?

azasypkin · 2020-11-11T11:41:40Z

x-pack/plugins/spaces/server/spaces_service/spaces_service.ts


 type RequestFacade = KibanaRequest | Legacy.Request;

 export interface SpacesServiceSetup {
-  scopedClient(request: RequestFacade): Promise<SpacesClient>;
+  scopedClient(request: RequestFacade): ISpacesClient;


question: any reason we don't want consumers to perform conversion to a KibanaRequest on their own in case they need to? I'd honestly prefer us having a clean public API and keep workarounds with RequestFacade within a context that makes it clear why workaround is needed.

I'll investigate -- we needed the RequestFacade earlier in the NP migration, but that might have been to interop with plugins that still lived in the LP. Now that we're fully migrated, we might be able to clean this up.

I think I have this working. It involved changing the way that Alerts and Actions construct their fake requests, but pending review from the alerting team, this should be good!

azasypkin · 2020-11-11T11:48:04Z

x-pack/plugins/spaces/server/spaces_service/spaces_service.ts

-    auditLogger,
-  }: SpacesServiceDeps): Promise<SpacesServiceSetup> {
+  public setup({ http, config$ }: SpacesServiceDeps): SpacesServiceSetup {
+    this.spacesClientService = new SpacesClientService(


nit: it seems we could also create this service in constructor and pass config$ in its setup method (to access this.spacesClientService methods without !)?

note: I made the SpacesClientService a start dependency of the SpacesService in a recent refactoring, so the SpacesService is no longer responsible for constructing this instance.

azasypkin · 2020-11-11T12:33:23Z

x-pack/plugins/spaces/server/spaces_service/spaces_service.ts

    };

    return {
+      scopedClient: getScopedClient,


question: do we expose scopedClient in setup just temporarily to make migration easier? It seems it's not really functional until start and we expose it through start as well (createSpacesClient).

If we still want to expose this for the aforementioned reasons, can we either unify method names between setup and start or somehow rename method we expose in setup so that it's clear that no one should use it if possible?

Great question. I was going to refactor this service to stop exposing so much out of setup, but that ended up causing a lot of downstream changes that I wasn't comfortable keeping in this PR, so I opted against it.

If we still want to expose this for the aforementioned reasons, can we either unify method names between setup and start or somehow rename method we expose in setup so that it's clear that no one should use it if possible?

++

I was going to refactor this service to stop exposing so much out of setup, but that ended up causing a lot of downstream changes that I wasn't comfortable keeping in this PR, so I opted against it.

Welp, I went and removed a bunch of functions from setup. It added a bit of scope to this PR, but I'm generally happier with it. If you're not comfortable with the scope creep, let me know and I'll split it out into a different PR.

Nah, let's keep it here, I believe this PR is an ideal place for a refactoring like this.

azasypkin · 2020-11-11T12:43:16Z

x-pack/plugins/spaces/server/spaces_service/spaces_service.test.ts

 };

 describe('SpacesService', () => {
  describe('#getSpaceId', () => {
    it('returns the default space id when no identifier is present', async () => {
-      const spacesServiceSetup = await createService();
+      const { spacesServiceSetup } = await createService();


nit: looks like we can make createService sync now and remove all these await in tests?

x-pack/plugins/security/server/spaces/secure_spaces_client_wrapper.ts

azasypkin · 2020-11-11T15:24:48Z

x-pack/plugins/security/server/spaces/secure_spaces_client_wrapper.ts

+  public async getAll({
+    purpose = 'any',
+    includeAuthorizedPurposes,
+  }: GetAllSpacesOptions = {}): Promise<Space[]> {


question: do we intentionally cast GetSpaceResult[] to Space[]?

Ah good catch - I think this should be GetSpaceResult[] instead.

x-pack/plugins/security/server/spaces/secure_spaces_client_wrapper.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>

- Reorganize top level describes into 3 space-based blocks into based on spaces: - space disabled - spaces plugin unavailable - space enabled (most previous tests go under this new block) with new beforeEach - wrote new tests for uncovered lines 58, 66-69

gmmorris

Actions, Alerts & EventLog LGTM 👍
In fact.. better than before ;)

legrego · 2020-11-17T00:46:33Z

Hey @gmmorris, would you mind re-reviewing this? The initial set of changes didn't consider the user's current space when alerts were running in the background, which caused this set of test failures.

As a result, I changed the way that Actions and Alerts constructed their fake requests to (IMO) better align with their intent. They were being incorrectly cast as a KibanaRequest before, which is how they slipped through my first pass.

I'm not sure if my approach is entirely correct or not though, so I'd appreciate a re-review to make sure that I didn't break anything related to Actions, Alerts, or the Event Log.

…-circular-dependency

gmmorris · 2020-11-17T10:00:28Z

x-pack/plugins/alerts/server/task_runner/task_runner.ts

+    const path = spaceId ? `/s/${spaceId}` : '/';
+
+    const fakeRequest = KibanaRequest.from(({
      headers: requestHeaders,
-      getBasePath: () => this.context.getBasePath(spaceId),


This change looks wrong to me... but I'm not actually sure.
I thought context.getBasePath was implemented by the Spaces plugin and so line 95 feels like Spaces domain... 🤔
In plugin.ts we do this:

private getBasePath = (spaceId?: string): string => { return this.spaces && spaceId ? this.spaces.getBasePath(spaceId) : this.serverBasePath!; };

Perhaps @mikecote can help here?

I thought context.getBasePath was implemented by the Spaces plugin and so line 95 feels like Spaces domain...

Yeah we were using getBasePath from the Spaces plugin in order to simulate a request coming from the Legacy platform. This PR removed support for the LP requests, and instead forces consumers to construct KibanaRequest instances. Alerting & Actions were creating a LP fake request, but casting it as a KibanaRequest.

One of the reasons to fake a request was so that the Spaces plugin could properly scope instances of the Saved Objects client. Since we aren't honoring LP requests anymore, there isn't a need to provide the getBasePath function -- rather, consumers need to inform core about the request's base path by calling core.http.basePath.set(fakeRequest, spaceAwarePath) instead.

^^^^^
At least, this is the intent behind my most recent set of changes.

@mikecote what are your thoughts?

consumers need to inform core about the request's base path by calling core.http.basePath.set(fakeRequest, spaceAwarePath) instead.

If that is their recommendation for now, I'm ok with this change. Alerting is hacking fake requests in Kibana until scope-able elasticsearch clients is around so we'll have some odd code to deal with until then either way.

In that case my review still stands, but on this specific question I'm relying on your understanding of this 😆

…-circular-dependency

legrego · 2020-11-18T15:59:26Z

@azasypkin ready for another review round. I made a lot of changes since your last review...sorry 😬

azasypkin · 2020-11-19T07:32:46Z

ACK: reviewing...

azasypkin

Looks great! Tested the most common scenarios locally and everything seems to be in order.

azasypkin · 2020-11-19T07:41:50Z

x-pack/plugins/actions/server/lib/task_runner_factory.ts

@@ -87,11 +88,12 @@ export class TaskRunnerFactory {
          requestHeaders.authorization = `ApiKey ${apiKey}`;
        }

+        const path = spaceId ? `/s/${spaceId}` : '/';


question: any reason why we cannot use already exported addSpaceIdToPath here (to leave /s/ logic to Spaces plugin)?

Good call, I don't see why we can't use that

x-pack/plugins/actions/server/plugin.ts

x-pack/plugins/alerts/server/plugin.ts

azasypkin · 2020-11-19T07:49:27Z

x-pack/plugins/alerts/server/task_runner/task_runner.ts

@@ -91,9 +92,10 @@ export class TaskRunner {
      requestHeaders.authorization = `ApiKey ${apiKey}`;
    }

-    return ({
+    const path = spaceId ? `/s/${spaceId}` : '/';


question: same question about addSpaceIdToPath here.

azasypkin · 2020-11-19T07:59:51Z

x-pack/plugins/ml/server/shared_services/providers/system.ts

@@ -44,7 +44,10 @@ export function getMlSystemProvider(
          return await getGuards(request, savedObjectsClient)
            .isMinimumLicense()
            .ok(async ({ mlClient }) => {
-              const { isMlEnabledInSpace } = spacesUtilsProvider(spaces, request);
+              const { isMlEnabledInSpace } =
+                getSpaces !== undefined


question: do we really need this check here? It seems spacesUtilsProvider already does the right thing internally if getSpaces isn't defined.

Good catch, this was leftover from a previous (failed) implementation

x-pack/plugins/spaces/server/spaces_client/spaces_client_service.ts

azasypkin · 2020-11-19T10:51:42Z

x-pack/plugins/spaces/server/spaces_client/spaces_client_service.ts

+        const baseClient = new SpacesClient(
+          this.debugLogger,
+          this.config,
+          this.repositoryFactory!(request, coreStart.savedObjects)


note: no need to change anything here, just observation: if we move if (!this.repositoryFactory) { check inside of this method we will be able to get rid of ! in this.repositoryFactory! or even do something like this:

const repository = this.repositoryFactory ? this.repositoryFactory(request, coreStart.savedObjects) : coreStart.savedObjects.createScopedRepository(request, ['space']); const baseClient = new SpacesClient(this.debugLogger, this.config, repository);

azasypkin · 2020-11-19T10:59:47Z

x-pack/plugins/spaces/server/spaces_service/spaces_service.ts

+  createSpacesClient: SpacesClientServiceStart['createSpacesClient'];
+
+  /**
+   * Retrieves the space id associated with the provided request.


Thanks for adding documentation!

x-pack/plugins/spaces/server/spaces_service/spaces_service.ts

azasypkin · 2020-11-19T11:08:34Z

x-pack/plugins/spaces/server/spaces_service/spaces_service.ts

-  auditLogger: SpacesAuditLogger;
+interface SpacesServiceStartDeps {
+  basePath: IBasePath;
+  spacesClientService: SpacesClientServiceStart;
 }

 export class SpacesService {
  private configSubscription$?: Subscription;


nit: looks like we don't need this in this service anymore, and we may want to move this to SpacesClientService instead?

Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>

…-circular-dependency

legrego · 2020-11-18T15:06:50Z

x-pack/plugins/spaces/server/spaces_client/index.ts

@@ -0,0 +1,14 @@
+/*


😢 I thought this was going to be tracked as a move/rename. I moved the spaces_client directory out of the lib folder (as we discussed a long time ago during NP conversion). I didn't expect it to add too much noise to the PR...sorry about that!

I moved the spaces_client directory out of the lib folder (as we discussed a long time ago during NP conversion). I didn't expect it to add too much noise to the PR...sorry about that!

Haha, no worries, and thanks for reducing the amount of stuff we have in a lib folder!

legrego · 2020-11-18T15:08:29Z

x-pack/plugins/security/server/spaces/setup_spaces_client.ts

+  spaces?: SpacesPluginSetup;
+}
+
+export const setupSpacesClient = ({ audit, authz, spaces }: Deps) => {


note: This logic was part of server/plugin.ts during your initial review. I pulled it into its own file to better organize the spaces-related logic, and to facilitate unit testing.

x-pack/plugins/security/server/spaces/secure_spaces_client_wrapper.ts

legrego · 2020-11-19T14:53:43Z

x-pack/plugins/security/server/spaces/setup_spaces_client.ts

+}
+
+export const setupSpacesClient = ({ audit, authz, spaces }: Deps) => {
+  if (!spaces) {


No real reason -- plugin.ts is already pretty large, so I felt like "hiding" the conditional logic here would make scanning the plugin's setup function a little easier. I don't have a strong opinion here one way or another.

legrego · 2020-11-19T14:55:41Z

x-pack/plugins/spaces/server/lib/request_interceptors/on_post_auth_interceptor.test.ts

@@ -1,588 +0,0 @@
-/*


Thanks for asking, I meant to leave a comment here. My original plan was to port these to become jest integration tests, but that ended up more complex than I anticipated. I'll restore these tests for now so that they aren't lost to time.

legrego · 2020-11-19T15:07:04Z

x-pack/plugins/actions/server/lib/task_runner_factory.ts

@@ -87,11 +88,12 @@ export class TaskRunnerFactory {
          requestHeaders.authorization = `ApiKey ${apiKey}`;
        }

+        const path = spaceId ? `/s/${spaceId}` : '/';


Good call, I don't see why we can't use that

legrego · 2020-11-19T15:08:25Z

x-pack/plugins/ml/server/shared_services/providers/system.ts

@@ -44,7 +44,10 @@ export function getMlSystemProvider(
          return await getGuards(request, savedObjectsClient)
            .isMinimumLicense()
            .ok(async ({ mlClient }) => {
-              const { isMlEnabledInSpace } = spacesUtilsProvider(spaces, request);
+              const { isMlEnabledInSpace } =
+                getSpaces !== undefined


Good catch, this was leftover from a previous (failed) implementation

legrego · 2020-11-19T15:22:16Z

x-pack/plugins/spaces/server/plugin.test.ts

@@ -23,13 +23,13 @@ describe('Spaces Plugin', () => {
      const spacesSetup = await plugin.setup(core, { features, licensing });
      expect(spacesSetup).toMatchInlineSnapshot(`
        Object {
+          "spacesClient": Object {


Yup, great idea! I'm also removing async from the setup phase too -- we don't need it anymore.

x-pack/plugins/spaces/server/spaces_client/spaces_client.ts

legrego · 2020-11-19T15:28:54Z

x-pack/plugins/spaces/server/spaces_client/spaces_client.ts

+  public async delete(id: string) {
+    const existingSavedObject = await this.repository.get('space', id);
+    if (isReservedSpace(this.transformSavedObjectToSpace(existingSavedObject))) {
+      throw Boom.badRequest('This Space cannot be deleted because it is reserved.');


It can't hurt!

jgowdyelastic

ML changes LGTM

kibanamachine · 2020-11-19T18:34:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0bd2896

Metrics [docs]

Distributable file count

id	before	after	diff
`default`	42888	42894	+6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`spaces`	290.5KB	290.9KB	+321.0B

History

💔 Build #88966 failed 26074a7
💔 Build #88956 failed d8c3de0
💚 Build #88549 succeeded 0a4a045
💚 Build #88212 succeeded e974624
💚 Build #88120 succeeded 5258acc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Removing circular dependency between spaces and security * Apply suggestions from code review Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com> * Tests refactor - Reorganize top level describes into 3 space-based blocks into based on spaces: - space disabled - spaces plugin unavailable - space enabled (most previous tests go under this new block) with new beforeEach - wrote new tests for uncovered lines 58, 66-69 * Review1: address PR feedback * changing fake requests for alerts/actions * Fixing tests * fixing more tests * Additional testing and refactoring * Apply suggestions from code review Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com> * Review 2: Address feedback * Make ESLint happy again Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com> Co-authored-by: Constance Chen <constance.chen.3@gmail.com>

… (#83841) * Removing circular dependency between spaces and security * Apply suggestions from code review Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com> * Tests refactor - Reorganize top level describes into 3 space-based blocks into based on spaces: - space disabled - spaces plugin unavailable - space enabled (most previous tests go under this new block) with new beforeEach - wrote new tests for uncovered lines 58, 66-69 * Review1: address PR feedback * changing fake requests for alerts/actions * Fixing tests * fixing more tests * Additional testing and refactoring * Apply suggestions from code review Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com> * Review 2: Address feedback * Make ESLint happy again Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com> Co-authored-by: Constance Chen <constance.chen.3@gmail.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com> Co-authored-by: Constance Chen <constance.chen.3@gmail.com>

legrego force-pushed the spaces/remove-circular-dependency branch 9 times, most recently from ca60798 to bc12f7f Compare November 9, 2020 18:22

Removing circular dependency between spaces and security

255f0ba

legrego force-pushed the spaces/remove-circular-dependency branch from bc12f7f to 255f0ba Compare November 9, 2020 19:13

legrego commented Nov 9, 2020

View reviewed changes

legrego added release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.11 v8.0.0 labels Nov 9, 2020

legrego marked this pull request as ready for review November 9, 2020 20:51

legrego requested a review from a team November 9, 2020 20:51

legrego requested a review from a team as a code owner November 9, 2020 20:51

azasypkin self-requested a review November 10, 2020 11:18

legrego mentioned this pull request Nov 10, 2020

Show user information on space selector screen #83076

Closed

cee-chen reviewed Nov 10, 2020

View reviewed changes

x-pack/plugins/enterprise_search/server/lib/check_access.test.ts Outdated Show resolved Hide resolved

x-pack/plugins/enterprise_search/server/lib/check_access.ts Outdated Show resolved Hide resolved

x-pack/plugins/enterprise_search/server/lib/check_access.ts Outdated Show resolved Hide resolved

azasypkin reviewed Nov 11, 2020

View reviewed changes

legrego and others added 2 commits November 12, 2020 07:47

Apply suggestions from code review

d57da03

Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>

Tests refactor

ea217a5

- Reorganize top level describes into 3 space-based blocks into based on spaces: - space disabled - spaces plugin unavailable - space enabled (most previous tests go under this new block) with new beforeEach - wrote new tests for uncovered lines 58, 66-69

spalger added v7.11.0 and removed v7.11 labels Nov 12, 2020

Review1: address PR feedback

64f5cec

legrego requested a review from a team as a code owner November 16, 2020 14:23

gmmorris approved these changes Nov 16, 2020

View reviewed changes

cee-chen approved these changes Nov 16, 2020

View reviewed changes

legrego added 3 commits November 16, 2020 12:42

changing fake requests for alerts/actions

26cecc5

Fixing tests

d8a3392

fixing more tests

5258acc

legrego requested a review from gmmorris November 17, 2020 00:46

Merge branch 'master' of github.com:elastic/kibana into spaces/remove…

e974624

…-circular-dependency

gmmorris reviewed Nov 17, 2020

View reviewed changes

legrego added 2 commits November 18, 2020 07:36

Merge branch 'master' of github.com:elastic/kibana into spaces/remove…

76538c7

…-circular-dependency

Additional testing and refactoring

0a4a045

legrego requested a review from azasypkin November 18, 2020 15:59

azasypkin approved these changes Nov 19, 2020

View reviewed changes

legrego and others added 3 commits November 19, 2020 10:32

Apply suggestions from code review

d8c3de0

Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>

Review 2: Address feedback

9c544f3

Merge branch 'master' of github.com:elastic/kibana into spaces/remove…

26074a7

…-circular-dependency

legrego commented Nov 19, 2020

View reviewed changes

jgowdyelastic approved these changes Nov 19, 2020

View reviewed changes

Make ESLint happy again

0bd2896

legrego merged commit 7f962e5 into elastic:master Nov 19, 2020

legrego deleted the spaces/remove-circular-dependency branch November 19, 2020 18:41

legrego mentioned this pull request Nov 19, 2020

[7.x] Removing circular dependency between spaces and security (#81891) #83841

Merged

legrego mentioned this pull request Nov 19, 2020

[Meta] Migrate Kibana plugins to TS project references #80508

Closed

pmuellr mentioned this pull request Nov 20, 2020

[event_log] index event docs in bulk instead of individually #80941

Merged

		@@ -58,30 +62,33 @@ export class Plugin {

		private defaultSpaceService?: DefaultSpaceService;

		private spacesService?: SpacesService;

Removing circular dependency between spaces and security #81891

Removing circular dependency between spaces and security #81891

Conversation

legrego commented Oct 28, 2020 • edited Loading

Summary

Choose a reason for hiding this comment

legrego Nov 9, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Nov 9, 2020

azasypkin commented Nov 10, 2020

cee-chen left a comment

Choose a reason for hiding this comment

azasypkin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gmmorris left a comment

Choose a reason for hiding this comment

legrego commented Nov 17, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

legrego commented Nov 18, 2020

azasypkin commented Nov 19, 2020

azasypkin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jgowdyelastic left a comment

Choose a reason for hiding this comment

kibanamachine commented Nov 19, 2020

💚 Build Succeeded

Metrics [docs]

Distributable file count

Page load bundle

History

legrego commented Oct 28, 2020 •

edited

Loading

legrego Nov 9, 2020 •

edited

Loading