Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user information on space selector screen #83076

Closed
legrego opened this issue Nov 10, 2020 · 7 comments
Closed

Show user information on space selector screen #83076

legrego opened this issue Nov 10, 2020 · 7 comments
Labels
enhancement New value added to drive a business result Feature:Security/Spaces Platform Security - Spaces feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@legrego
Copy link
Member

legrego commented Nov 10, 2020

Once the circular dependency between Spaces and Security is resolved (#81891), we will be able to have the security plugin augment the Space Selector UI to include user information.

This is beneficial because we can allow users to logout if they realize they've chosen the wrong account.

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! enhancement New value added to drive a business result Feature:Security/Spaces Platform Security - Spaces feature labels Nov 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego
Copy link
Member Author

legrego commented Feb 10, 2021

I wonder if we should aim to show the black Elastic navbar on the space selector screen? What's that called, the Global Nav Bar?

@elastic/kibana-design this is not at all a priority for us right now, but if someone wants a fun side-quest, I'd happily accept a wireframe/mockup for this. Or reply with a simple "yes show the global nav bar" 🙂

@ryankeairns
Copy link
Contributor

Or Option C, wherein I ask clarifying questions 😄

My initial reaction is "Yeah ok, we are using the black bar everywhere."
Then, my questions are, for this particular case

  • Is the strictly to offer a log out link?
  • Where would the home/logo button take the user?
  • We wouldn't have any other items like search, support, What's new, etc. right?

Even without all that, a black header bar may still work (it might just have a Logout button on the right end). Otherwise, we might just find a spot for a simple log out button without adding a black header bar.

@legrego
Copy link
Member Author

legrego commented Feb 10, 2021

The primary motivation is to show a logout link, but it'd also be good to show the user's avatar/info, just to reinforce the fact that they authenticated as a specific user, and that they are in fact logged in.

@ryankeairns
Copy link
Contributor

Ok, I see. To my knowledge, we haven't displayed only the black bar, so we might consider showing the white bar as well even if it has but one breadcrumb. Additionally, we might make this look more like a standard page (i.e. not have the background graphics).

In short, give it a go with the stacked header (both bars) with the minimal content. We can help with tidying things up once you have a PR.


As a visual example, we'll probably end up with something that looks like the Enterprise Search overview page sans the graphic under the header and the extra header features (search, support, etc.):

Screen Shot 2021-02-10 at 10 44 19 AM

My very quick hack job via the Inspector to remove some stuff:

Screen Shot 2021-02-10 at 10 48 00 AM

@legrego
Copy link
Member Author

legrego commented Feb 10, 2021

Thanks @ryankeairns, much appreciated! In the stacked header example, we wouldn't have the Space avatar in the white bar either, since the user hasn't technically entered a space yet

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Aug 5, 2021
@legrego legrego removed EnableJiraSync loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 18, 2022
@legrego
Copy link
Member Author

legrego commented Aug 25, 2022

Closing this in favor of the redesigned space selector that we are planning on implementing.

@legrego legrego closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Security/Spaces Platform Security - Spaces feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

3 participants