Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [SIEM] Fixes a bug where invalid regular expressions within the index patterns can cause UI toaster errors (#73754) #73952

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

FrankHassanabad
Copy link
Contributor

Backports the following commits to 7.x:

… patterns can cause UI toaster errors (elastic#73754)

## Summary

elastic#49753

When you have no data you get a toaster error when we don't want a toaster error.

Before with the toaster error:
![error](https://user-images.githubusercontent.com/1151048/88860918-0e2a5900-d1ba-11ea-95e7-5ed7324fc831.png)

After:
You don't get an error toaster because I catch any regular expression errors and do not report them up to the UI.

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@FrankHassanabad FrankHassanabad merged commit b8f2749 into elastic:7.x Jul 31, 2020
@FrankHassanabad FrankHassanabad deleted the backport/7.x/pr-73754 branch July 31, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants