[SIEM] When no siem:defaultIndex is configured, 'SIEM job fetch failure' error shouldn't be displayed
#49753
Labels
bug
Fixes for quality problems that affect the customer experience
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:SIEM
v7.5.0
Comments
|
Pinging @elastic/siem (Team:SIEM) |
|
@MadameSheema this behavior is still present on 7.9.0-snapshot, albeit a little different... 😅
|
1 task
FrankHassanabad
added a commit
that referenced
this issue
Jul 31, 2020
… patterns can cause UI toaster errors (#73754) ## Summary #49753 When you have no data you get a toaster error when we don't want a toaster error. Before with the toaster error:  After: You don't get an error toaster because I catch any regular expression errors and do not report them up to the UI. ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this issue
Jul 31, 2020
… patterns can cause UI toaster errors (elastic#73754) ## Summary elastic#49753 When you have no data you get a toaster error when we don't want a toaster error. Before with the toaster error:  After: You don't get an error toaster because I catch any regular expression errors and do not report them up to the UI. ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
1 task
FrankHassanabad
added a commit
that referenced
this issue
Jul 31, 2020
… patterns can cause UI toaster errors (#73754) (#73952) ## Summary #49753 When you have no data you get a toaster error when we don't want a toaster error. Before with the toaster error:  After: You don't get an error toaster because I catch any regular expression errors and do not report them up to the UI. ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
FrankHassanabad
added a commit
that referenced
this issue
Jul 31, 2020
…ty spaces (#73991) ## Summary Fixes fully this issue: #49753 If you go to advanced settings and configure siemDefaultIndex to be an empty string or have empty spaces: <img width="1291" alt="Screen Shot 2020-07-31 at 12 52 00 PM" src="https://user-images.githubusercontent.com/1151048/89067511-a9434000-d32c-11ea-9106-e2079a5db317.png"> You shouldn't get any toaster errors when going to any of the pages such as overview, detections, etc... This fixes that and adds both unit and integration tests around those areas. The fix is to add a filter which will filter all the patterns out that are either empty strings or have the _all within them rather than just looking for a single value to exist. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this issue
Jul 31, 2020
…ty spaces (elastic#73991) ## Summary Fixes fully this issue: elastic#49753 If you go to advanced settings and configure siemDefaultIndex to be an empty string or have empty spaces: <img width="1291" alt="Screen Shot 2020-07-31 at 12 52 00 PM" src="https://user-images.githubusercontent.com/1151048/89067511-a9434000-d32c-11ea-9106-e2079a5db317.png"> You shouldn't get any toaster errors when going to any of the pages such as overview, detections, etc... This fixes that and adds both unit and integration tests around those areas. The fix is to add a filter which will filter all the patterns out that are either empty strings or have the _all within them rather than just looking for a single value to exist. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
FrankHassanabad
added a commit
that referenced
this issue
Jul 31, 2020
…ty spaces (#73991) (#74020) ## Summary Fixes fully this issue: #49753 If you go to advanced settings and configure siemDefaultIndex to be an empty string or have empty spaces: <img width="1291" alt="Screen Shot 2020-07-31 at 12 52 00 PM" src="https://user-images.githubusercontent.com/1151048/89067511-a9434000-d32c-11ea-9106-e2079a5db317.png"> You shouldn't get any toaster errors when going to any of the pages such as overview, detections, etc... This fixes that and adds both unit and integration tests around those areas. The fix is to add a filter which will filter all the patterns out that are either empty strings or have the _all within them rather than just looking for a single value to exist. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When no
siem:defaultIndexis configured and we're showing the placeholder overview for each page, we shouldn't show theSIEM job fetch failureerror as it is not helpful to the user, and adding indices as the page suggest will resolve the issue.E.g.
The text was updated successfully, but these errors were encountered: