-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[i18n] integrate new translations + new i18n check #70193" #71039
Conversation
(elastic#70423)" This reverts commit 2212beb.
💔 Build Failed
Failed CI StepsTest FailuresX-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/basic/tests/find_statuses·ts.detection engine api security and spaces enabled find_statuses "after each" hook for "should return a single rule status when a single rule is loaded from a find status with defaults added"Standard Out
Stack Trace
Build metrics
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR will break the CI step Internationalization check.
Maybe we can fix the removal of the translations by adding them through the right procedure?
cc/ @elastic/kibana-localization @chiweichang ?
Closing this after our offline conversion about this topic. We'll just wait for the correct translations! |
Thanks for following up while i was on vacation. Yes these missing labels will be reintroduced once we receive the new extracted labels from translators on the next FF. This new check is very important to avoid any runtime UI errors in case we have malformed translation labels. The most important branch to contain the translations is the |
That PR is an attempt to revert #70423
@XavierM reported the mentioned PR broke the translations for security solutions. As the original PR was not backported yet I believe we will be better by just revert it for now.
@Bamieh @afharo could you please verify if it reverts everything as expected?