Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] integrate new translations + new i18n check #70193 #70423

Merged
merged 3 commits into from
Jul 1, 2020
Merged

[i18n] integrate new translations + new i18n check #70193 #70423

merged 3 commits into from
Jul 1, 2020

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Jul 1, 2020

Summary

Integrate 7.8.2 translations.

Added a new i18n check to parse i18n messages. Sometimes we get malformed strings which cause kibana to fail at runtime.

Closes #69269
Closes #68220
Closes #35463

Example failing message:

{
"data.search.aggs.buckets.dateHistogram.extendedBounds.help": "CDATA[extended_bounds設定を使用すると、強制的にヒストグラムアグリゲーションを実行し、特定の最小値に対してバケットの作成を開始し、最大値までバケットを作成し続けます。 ]]></target>\n\t\t\t<note>Kibana-SW - String \"data.search.aggs.buckets.dateHistogram.extendedBounds.help\" in Json.Root \"messages\\strings\" ",
}

@Bamieh Bamieh requested a review from a team as a code owner July 1, 2020 11:38
@Bamieh Bamieh added release_note:skip Skip the PR/issue when compiling release notes v7.8.1 v7.9.0 v8.0.0 labels Jul 1, 2020
@Bamieh Bamieh mentioned this pull request Jul 1, 2020
Closed
afharo
afharo approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm only concerned about all the modifications in the translation files. Maybe something to be dealt with in a separate issue?

mistic
mistic approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afharo
Copy link
Member

afharo commented Jul 1, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh Bamieh merged commit 2212beb into elastic:master Jul 1, 2020
@Bamieh Bamieh deleted the i18n/new_checker branch July 1, 2020 15:48
This was referenced Jul 1, 2020
Closed
Closed
Bamieh added a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020
@Bamieh
[i18n] integrate new translations + new i18n check elastic#70193 (ela…
485d7ce 
…stic#70423)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 3, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

mistic added a commit to mistic/kibana that referenced this pull request Jul 8, 2020
@mistic
Revert "[i18n] integrate new translations + new i18n check elastic#70193
99a27e7 
 (elastic#70423)"

This reverts commit 2212beb.
@mistic mistic mentioned this pull request Jul 8, 2020
Closed
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

This was referenced Jul 11, 2020
Merged
Merged
Bamieh added a commit to Bamieh/kibana that referenced this pull request Jul 11, 2020
@Bamieh
[i18n] integrate new translations + new i18n check elastic#70193 (ela…
69376e7 
…stic#70423)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
Bamieh added a commit that referenced this pull request Jul 11, 2020
@Bamieh @elasticmachine
[7.x] [i18n] integrate new translations + new i18n check #70193 (#70423…
9b56184 
…) (#71388)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Bamieh added a commit that referenced this pull request Jul 11, 2020
@Bamieh @elasticmachine
[7.8] [i18n] integrate new translations + new i18n check #70193 (#70423…
98a855c 
…) (#71389)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 11, 2020
@sorenlouv sorenlouv mentioned this pull request Jul 23, 2020
Merged
@Bamieh Bamieh mentioned this pull request Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.8.1 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@Bamieh @afharo @kibanamachine @mistic @elasticmachine