[Uptime] Add Alerting UI #57919

justinkambic · 2020-02-18T21:13:38Z

Summary

Introduce alerting UI to Uptime app.

Running this PR

There are a few configuration settings that must be enabled for alerting/actions to work. In your kibana.yml, specify the following:

xpack.actions.enabled: true
xpack.alerting.enabled: true
xpack.task_manager.enabled: true
xpack.triggers_actions_ui.enabled: true

In addition, make sure security is enabled for ES. You'll also need to use SSL for Elasticsearch and Kibana, you can do that with the following commands:

yarn start --ssl
yarn es snapshot --ssl

Also, you'll have to configure Heartbeat so it will work with ES in this configuration.

output.elasticsearch:
  ssl:
    certificate_authorities: ${AUTH}
    certificate: ${CERT}
    key: ${KEY}

You can find the necessary objects for these keys in your Kibana repo:

~/kibana/packages/kbn-dev-utils/certs/ca.crt
~/kibana/packages/kbn-dev-utils/certs/elasticsearch.crt
~/kibana/packages/kbn-dev-utils/certs/elasticsearch.key

Once you get all that running, you're ready to look at the new functionality.

New functionality

We've added the beta Add Alert Flyout component to the Uptime app in this branch. You can access the flyout using the new popover button this PR introduces:

Upon opening the alert flyout, you can select the alert type this patch introduces, Monitor Status.

From here you can specify the alert parameters, as well as some custom filtering and logic the alert type defines.

Define a connector (I typically use server log) and create an alert. You should be able to see messages getting logged to your Kibana server log. There are several context fields you can include in your messages as well, and they're populated in the connector field by default:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-02-18T21:13:41Z

Pinging @elastic/uptime (Team:uptime)

Add new alert type for Uptime. Add defensive checks to alert executor. Move status check code to dedicated adapter function. Clean up code.

… from placeholder value.

justinkambic · 2020-03-17T21:09:34Z

Alert Type seems weird for id: "xpack.uptime.alerts.downMonitor"

Good catch on this one.

Fixed in e482f08.

shahzad31

LGTM !!

justinkambic · 2020-03-18T13:25:11Z

@elasticmachine merge upstream

katrin-freihofner

I added a few minor wording/icon changes

katrin-freihofner

👍

katrin-freihofner · 2020-03-18T15:01:15Z

x-pack/legacy/plugins/uptime/public/components/functional/alerts/toggle_alert_flyout_button.tsx

+        >
+          <FormattedMessage
+            id="xpack.uptime.alerts.toggleAlertFlyoutButtonText"
+            defaultMessage="Alerting"


Suggested change

defaultMessage="Alerting"

defaultMessage="Alerts"

Addressed in 2519a8c.

katrin-freihofner · 2020-03-18T15:01:30Z

x-pack/legacy/plugins/uptime/public/components/functional/alerts/toggle_alert_flyout_button.tsx

+          <EuiContextMenuItem
+            data-test-subj="xpack.uptime.toggleAlertFlyout"
+            key="create-alert"
+            icon="plusInCircle"


Suggested change

icon="plusInCircle"

icon="alert"

katrin-freihofner · 2020-03-18T15:01:47Z

x-pack/legacy/plugins/uptime/public/components/functional/alerts/toggle_alert_flyout_button.tsx

+          </EuiContextMenuItem>,
+          <EuiContextMenuItem
+            data-test-subj="xpack.uptime.navigateToAlertingUi"
+            icon="gear"


Suggested change

icon="gear"

icon="tableOfContents"

justinkambic · 2020-03-18T18:11:25Z

@katrin-freihofner I think I've implemented your feedback on the copy/icons.

shahzad31

LGTM !!

justinkambic · 2020-03-19T14:12:18Z

@elasticmachine merge upstream

kibanamachine · 2020-03-19T23:41:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4329fc6

History

💚 Build #34535 succeeded 4329fc6
💛 Build #34369 was flaky d1e3d19
💔 Build #34286 failed 2519a8c
💚 Build #34179 succeeded 04c5fff
💛 Build #34154 was flaky f0066db

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2020-03-20T16:58:46Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2020-03-21T17:08:44Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

Backports the following commits to 7.x: [Uptime] Add Alerting UI (#57919)

justinkambic added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 labels Feb 18, 2020

justinkambic requested a review from a team as a code owner February 18, 2020 21:13

justinkambic self-assigned this Feb 18, 2020

justinkambic force-pushed the uptime_alerting-ui branch 3 times, most recently from 00410dd to d366a6e Compare March 2, 2020 17:39

justinkambic added 22 commits March 3, 2020 08:54

WIP trying things.

8f43e13

Add new alert type for Uptime. Add defensive checks to alert executor. Move status check code to dedicated adapter function. Clean up code.

Port adapter function to dedicated file.

4778670

WIP.

724fea8

Working on parameter selection.

3f17b51

Selector expressions working.

b62d15b

Working on actions.

5814074

Change anchor prop for popovers.

99abd50

Reference migrated alerting plugin.

8e07e73

Clean up code for draft.

92ff59d

Add button to expose flyout. Clean up some client code.

7adcfc4

Add test for requests function, add support for filters.

33ca971

Reorganize and clean up files.

9ec182f

Add location and filter support to monitor status request function.

06fe939

Add tests for monitor status request function.

5302078

Specify default action group id in alert registration.

103cb46

Extract repeated string value to a constant.

b9eb062

Move test file to server in NP plugin.

e2c9429

Update imports after NP migration.

adfe4c9

Fix UI bug that caused incorrect location selections in alert creation.

c465503

Change alert expression language to clarify meaning.

8e21ba7

Add ability for user to select timerange units.

96befca

Add code that fixes active item highlighting.

fc9e349

Update the id and name of our alert type because it was never changed…

e482f08

… from placeholder value.

justinkambic added 3 commits March 17, 2020 18:45

Rename alert keys.

ab40de8

Fix broken unit tests.

42a3a5d

Merge branch 'master' into uptime_alerting-ui

65e6519

shahzad31 approved these changes Mar 18, 2020

View reviewed changes

elasticmachine and others added 2 commits March 18, 2020 09:25

Merge branch 'master' into uptime_alerting-ui

f0066db

Merge branch 'master' into uptime_alerting-ui

04c5fff

katrin-freihofner reviewed Mar 18, 2020

View reviewed changes

justinkambic added 3 commits March 18, 2020 12:03

Merge branch 'master' into uptime_alerting-ui

d7d8905

Add aria-labels to alert UI.

74006e2

Implement design feedback.

2519a8c

justinkambic added 3 commits March 18, 2020 18:31

Merge branch 'master' into uptime_alerting-ui

7034654

Fix broken test snapshots.

7006288

Add missing props to unit tests to staisfy updated types.

d1e3d19

shahzad31 approved these changes Mar 19, 2020

View reviewed changes

Merge branch 'master' into uptime_alerting-ui

4329fc6

justinkambic merged commit fcf4396 into elastic:master Mar 19, 2020

justinkambic mentioned this pull request Mar 19, 2020

[7.x] [Uptime] Add Alerting UI (#57919) #60657

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 20, 2020

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 22, 2020

andrewvc pushed a commit that referenced this pull request Mar 22, 2020

[7.x] [Uptime] Add Alerting UI (#57919) (#60657)

e302cdc

Backports the following commits to 7.x: [Uptime] Add Alerting UI (#57919)

justinkambic mentioned this pull request Mar 25, 2020

[Uptime] Alerting implementation #56196

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Add Alerting UI #57919

[Uptime] Add Alerting UI #57919

justinkambic commented Feb 18, 2020 •

edited

Loading

elasticmachine commented Feb 18, 2020

justinkambic commented Mar 17, 2020

shahzad31 left a comment

justinkambic commented Mar 18, 2020

katrin-freihofner left a comment

katrin-freihofner left a comment

katrin-freihofner Mar 18, 2020

justinkambic Mar 18, 2020

katrin-freihofner Mar 18, 2020

justinkambic Mar 18, 2020

katrin-freihofner Mar 18, 2020

justinkambic Mar 18, 2020

justinkambic commented Mar 18, 2020

shahzad31 left a comment

justinkambic commented Mar 19, 2020

kibanamachine commented Mar 19, 2020

kibanamachine commented Mar 20, 2020

kibanamachine commented Mar 21, 2020

[Uptime] Add Alerting UI #57919

[Uptime] Add Alerting UI #57919

Conversation

justinkambic commented Feb 18, 2020 • edited Loading

Summary

Running this PR

New functionality

Checklist

For maintainers

elasticmachine commented Feb 18, 2020

justinkambic commented Mar 17, 2020

shahzad31 left a comment

Choose a reason for hiding this comment

justinkambic commented Mar 18, 2020

katrin-freihofner left a comment

Choose a reason for hiding this comment

katrin-freihofner left a comment

Choose a reason for hiding this comment

katrin-freihofner Mar 18, 2020

Choose a reason for hiding this comment

justinkambic Mar 18, 2020

Choose a reason for hiding this comment

katrin-freihofner Mar 18, 2020

Choose a reason for hiding this comment

justinkambic Mar 18, 2020

Choose a reason for hiding this comment

katrin-freihofner Mar 18, 2020

Choose a reason for hiding this comment

justinkambic Mar 18, 2020

Choose a reason for hiding this comment

justinkambic commented Mar 18, 2020

shahzad31 left a comment

Choose a reason for hiding this comment

justinkambic commented Mar 19, 2020

kibanamachine commented Mar 19, 2020

💚 Build Succeeded

History

kibanamachine commented Mar 20, 2020

kibanamachine commented Mar 21, 2020

justinkambic commented Feb 18, 2020 •

edited

Loading