Skip to content

Commit

Permalink
Update the id and name of our alert type because it was never changed…
Browse files Browse the repository at this point in the history
… from placeholder value.
  • Loading branch information
justinkambic committed Mar 17, 2020
1 parent ef6b687 commit e482f08
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,8 @@ describe('status check alert', () => {
});

it('contains the expected static fields like id, name, etc.', () => {
expect(alert.id).toBe('xpack.uptime.alerts.downMonitor');
expect(alert.name).toBe('X-Pack Alerting');
expect(alert.id).toBe('xpack.uptime.alerts.monitorStatus');
expect(alert.name).toBe('Uptime Monitor Status');
expect(alert.defaultActionGroupId).toBe('xpack.uptime.alerts.actionGroups.downMonitor');
expect(alert.actionGroups).toMatchInlineSnapshot(`
Array [
Expand Down
6 changes: 4 additions & 2 deletions x-pack/plugins/uptime/server/lib/alerts/status_check.ts
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,10 @@ export const updateState = (
const DEFAULT_MAX_MESSAGE_ROWS = 3;

export const statusCheckAlertFactory: UptimeAlertTypeFactory = (server, libs) => ({
id: 'xpack.uptime.alerts.downMonitor',
name: 'X-Pack Alerting',
id: 'xpack.uptime.alerts.monitorStatus',
name: i18n.translate('xpack.uptime.alerts.monitorStatus', {
defaultMessage: 'Uptime Monitor Status',
}),
validate: {
params: schema.object({
filters: schema.maybe(schema.string()),
Expand Down

0 comments on commit e482f08

Please sign in to comment.