Cancel discarded KQL value suggestion requests #51411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
streamich
approved these changes
Dec 5, 2019
lizozom
reviewed
Dec 9, 2019
| @@ -22,7 +22,7 @@ export const kueryProvider = ({ config, indexPatterns, boolFilter }) => { | |||
| return provider({ config, indexPatterns, boolFilter }); | |||
| }); | |||
|
|
|||
| return function getSuggestions({ query, selectionStart, selectionEnd }) { | |||
| return function getSuggestions({ query, selectionStart, selectionEnd, signal }) { | |||
There was a problem hiding this comment.
// nit
Can\will the signal be used for anything but aborting?
If not, maybe call it abortSignal?
lizozom
reviewed
Dec 9, 2019
| @@ -112,7 +112,7 @@ describe('Kuery value suggestions', function () { | |||
| const spy = jest.spyOn(npStart.plugins.data, 'getSuggestions'); | |||
| await getSuggestions({ fieldName, prefix, suffix }); | |||
| expect(spy).toHaveBeenCalledTimes(1); | |||
| expect(spy).toBeCalledWith(expect.any(String), expect.any(Object), prefix + suffix, undefined); | |||
| expect(spy).toBeCalledWith(expect.any(String), expect.any(Object), prefix + suffix, undefined, undefined); | |||
There was a problem hiding this comment.
Maybe add a test where signal is defined as well?
lizozom
approved these changes
Dec 9, 2019
|
@elasticmachine merge upstream |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Dec 9, 2019
* Fix filter matches index for filters with partial meta * Abort discarded KQL value suggestion requests * Abort server-side connection to ES * Fix failing test
|
7.x (7.6.0): 80d35bd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #48797.
This PR cancels requests initiating from the KQL query bar for value suggestions when a new request is made. This should eliminate much of the extra load in large clusters when requests take longer than the time it takes to type a new character.
To do:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers
Release notes
When querying Elasticsearch for value suggestions on specific fields in KQL, we will now cancel any previous, incomplete requests for value suggestions.