Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search service] Integrate with aborted$ event to cancel discarded requests #55490

Closed
lukasolson opened this issue Jan 21, 2020 · 1 comment · Fixed by #56788
Closed

[Search service] Integrate with aborted$ event to cancel discarded requests #55490

lukasolson opened this issue Jan 21, 2020 · 1 comment · Fixed by #56788
Assignees
Labels
Feature:Search Querying infrastructure in Kibana

Comments

@lukasolson
Copy link
Member

lukasolson commented Jan 21, 2020

Waiting on #44302 (PR: #55061), #48811 (PR: #53057).

In the legacy platform, the endpoints that the search APIs hit would listen to HapiJS's disconnect event. However, it was not exposed in the new platform (thus the issue raised above).

When #55061 is merged, we will need to update the search service to take advantage of these events and properly abort the requests to Elasticsearch (in both the sync and async strategies).

Note: We should also add integration in other places we are cancelling requests that are in the new platform, like KQL value suggestions (see #51411, #54451).

@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana Team:AppArch labels Jan 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukasolson lukasolson changed the title [Search service] Integrate with aborted$ event [Search service] Integrate with aborted$ event to cancel discarded requests Jan 21, 2020
@lukasolson lukasolson self-assigned this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants