Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all code associated with node-ctags #51405

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Remove all code associated with node-ctags #51405

merged 2 commits into from
Nov 22, 2019

Conversation

epixa
Copy link
Contributor

@epixa epixa commented Nov 21, 2019

This was only used by the code plugin, which was removed in 7.5.0.

@epixa
Remove all code associated with node-ctags
38c689e 
This was only used by the code plugin, which was removed in 7.5.0.
@epixa epixa added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Nov 21, 2019
@epixa epixa requested a review from a team as a code owner November 21, 2019 23:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger
Copy link
Contributor

spalger commented Nov 22, 2019

Flaky test skipped in #40912

@spalger
Copy link
Contributor

spalger commented Nov 22, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

mistic
mistic approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epixa epixa merged commit c9c4f79 into elastic:master Nov 22, 2019
@epixa epixa deleted the code-dep-node-ctags branch November 22, 2019 12:39
@epixa epixa mentioned this pull request Nov 22, 2019
Merged
epixa added a commit that referenced this pull request Nov 22, 2019
@epixa
Remove all code associated with node-ctags (#51405) (#51434)
b1d1b78 
This was only used by the code plugin, which was removed in 7.5.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@epixa @elasticmachine @spalger @mistic