Skip to content

Commit

Permalink
Remove all code associated with node-ctags (#51405) (#51434)
Browse files Browse the repository at this point in the history
This was only used by the code plugin, which was removed in 7.5.0.
  • Loading branch information
epixa authored Nov 22, 2019
1 parent 51f3f24 commit b1d1b78
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 43 deletions.
2 changes: 0 additions & 2 deletions src/dev/build/build_distributables.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import {
CleanTypescriptTask,
CleanNodeBuildsTask,
CleanTask,
CleanCtagBuildTask,
CopySourceTask,
CreateArchivesSourcesTask,
CreateArchivesTask,
Expand Down Expand Up @@ -133,7 +132,6 @@ export async function buildDistributables(options) {
await run(CleanExtraBinScriptsTask);
await run(CleanExtraBrowsersTask);
await run(CleanNodeBuildsTask);
await run(CleanCtagBuildTask);

await run(PathLengthTask);

Expand Down
39 changes: 0 additions & 39 deletions src/dev/build/tasks/clean_tasks.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
import minimatch from 'minimatch';

import { deleteAll, deleteEmptyFolders, scanDelete } from '../lib';
import { resolve } from 'path';

const RELATIVE_CTAGS_BUILD_DIR = 'node_modules/@elastic/node-ctags/ctags/build';

export const CleanTask = {
global: true,
Expand Down Expand Up @@ -256,39 +253,3 @@ export const CleanEmptyFoldersTask = {
]);
},
};

export const CleanCtagBuildTask = {
description: 'Cleaning extra platform-specific files from @elastic/node-ctag build dir',

async run(config, log, build) {
const getPlatformId = platform => {
if (platform.isWindows()) {
return 'win32';
} else if (platform.isLinux()) {
return 'linux';
} else if (platform.isMac()) {
return 'darwin';
}
};

await Promise.all(
config.getTargetPlatforms().map(async platform => {
if (build.isOss()) {
return;
}

const ctagsBuildDir = build.resolvePathForPlatform(platform, RELATIVE_CTAGS_BUILD_DIR);
await deleteAll(
[
resolve(ctagsBuildDir, '*'),
`!${resolve(
ctagsBuildDir,
`ctags-node-v${process.versions.modules}-${getPlatformId(platform)}-x64`
)}`,
],
log
);
})
);
},
};
2 changes: 0 additions & 2 deletions src/dev/license_checker/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,4 @@ export const LICENSE_OVERRIDES = {

// TODO can be removed once we upgrade the use of walk dependency past or equal to v2.3.14
'walk@2.3.9': ['MIT'],

'@elastic/node-ctags@1.0.2': ['Nuclide software'],
};

0 comments on commit b1d1b78

Please sign in to comment.