Fix truncation of long filter bar items #43874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
TinaHeiligers
approved these changes
Aug 23, 2019
snide
approved these changes
Aug 27, 2019
| @@ -25,6 +25,15 @@ | |||
| transition: height $euiAnimSpeedNormal $euiAnimSlightResistance; | |||
| } | |||
|
|
|||
| .globalFilterGroup__filterFlexItem { | |||
| overflow: hidden; | |||
| padding-bottom: 2px; // Allow the shadows of the pills to show | |||
There was a problem hiding this comment.
Ahhh, ty for this. This bugged me forever.
a59aaf9 to
1a845c4
Compare
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35225
By porting over the SASS and classNames from the fix in EUI.
How it behaves now
Wrapping still works
Works in IE
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately