Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The window to edit filters is mispositioned if the filter is too long #35225

Closed
fdartayre opened this issue Apr 17, 2019 · 4 comments · Fixed by #43874
Closed

The window to edit filters is mispositioned if the filter is too long #35225

fdartayre opened this issue Apr 17, 2019 · 4 comments · Fixed by #43874
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@fdartayre
Copy link

fdartayre commented Apr 17, 2019

Kibana version: 7.0.0

Browser version: Chrome Version 70 and Firefox 60

Describe the bug:
The window to edit filters seems to positioned at the middle of the filter string. When the filter string is too long, the window is pushed to the top left and is not usable.

Screen capture:
filter

Steps to reproduce:
It's easily reproduced with a long DSL query like the one in the screen capture:

long query
{
  "query": {
    "bool": {
      "should": [
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        },
        {
          "match": {
            "service.type": "system"
          }
        }
      ]
    }
  }
}
@fdartayre fdartayre added bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. labels Apr 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@cchaos cchaos added Feature:Filters Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. labels Apr 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@cchaos cchaos added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Apr 17, 2019
@cchaos
Copy link
Contributor

cchaos commented Apr 17, 2019

This is both an implementation and design issue that hasn't properly dealt with long filter names.

@cchaos
Copy link
Contributor

cchaos commented Aug 2, 2019

The EuiBadge fixes are in EUI master, just needs a release and update in Kibana. Then I can port over the pattern fixes into Kibana.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants