[wip]: correct set tsconfig for mocha test under plugins/code/server/__test__

packages/kbn-plugin-helpers/lib/plugin_config.js

@@ -39,7 +39,7 @@ module.exports = function(root) {
     {
       root: root,
       kibanaRoot: pkg.name === 'x-pack' ? resolve(root, '..') : resolve(root, '../../kibana'),
-      serverTestPatterns: ['server/**/__tests__/**/*.js'],
+      serverTestPatterns: ['server/**/__tests__/**/*'],
       buildSourcePatterns: buildSourcePatterns,
       skipInstallDependencies: false,
       id: pkg.name,

src/dev/typescript/projects.ts

@@ -38,6 +38,9 @@ export const PROJECTS = [
   ...glob
     .sync('test/plugin_functional/plugins/*/tsconfig.json', { cwd: REPO_ROOT })
     .map(path => new Project(resolve(REPO_ROOT, path))),
+  ...glob
+    .sync('x-pack/plugins/**/__tests__/tsconfig.json', { cwd: REPO_ROOT })
+    .map(path => new Project(resolve(REPO_ROOT, path))),
 ];
 
 export function filterProjectsByFlag(projectFlag?: string) {

x-pack/.kibana-plugin-helpers.json

@@ -1,7 +1,7 @@
 {
   "serverTestPatterns": [
     "server/**/__tests__/**/*.js",
-    "plugins/**/__tests__/**/*.js",
+    "plugins/**/__tests__/**/*",
     "!plugins/**/server/**/__tests__/**/*"
   ],
   "buildSourcePatterns": [

x-pack/plugins/code/server/__tests__/clone_worker.ts

@@ -48,22 +48,20 @@ function cleanWorkspace() {
 }
 
 describe('clone_worker_tests', () => {
-  // @ts-ignore
   before(async () => {
     return new Promise(resolve => {
       rimraf(serverOptions.repoPath, resolve);
     });
   });
 
   beforeEach(async function() {
-    // @ts-ignore
     this.timeout(200000);
     await prepareProject(
       'https://github.com/Microsoft/TypeScript-Node-Starter.git',
       path.join(serverOptions.repoPath, 'github.com/Microsoft/TypeScript-Node-Starter')
     );
   });
-  // @ts-ignore
+
   after(() => {
     return cleanWorkspace();
   });

x-pack/plugins/code/server/__tests__/git_operations.ts

@@ -69,7 +69,6 @@ describe('git_operations', () => {
     return repo;
   }
 
-  // @ts-ignore
   before(async () => {
     await prepareProject(path.join(serverOptions.repoPath, repoUri));
   });

x-pack/plugins/code/server/__tests__/lsp_incremental_indexer.ts

@@ -127,22 +127,19 @@ function setupLsServiceSendRequestSpy(): sinon.SinonSpy {
 }
 
 describe('lsp_incremental_indexer unit tests', () => {
-  // @ts-ignore
   before(async () => {
     return new Promise(resolve => {
       rimraf(serverOptions.repoPath, resolve);
     });
   });
 
   beforeEach(async function() {
-    // @ts-ignore
     this.timeout(200000);
     return await prepareProject(
       'https://github.com/Microsoft/TypeScript-Node-Starter.git',
       path.join(serverOptions.repoPath, repoUri)
     );
   });
-  // @ts-ignore
   after(() => {
     return cleanWorkspace();
   });
@@ -197,7 +194,6 @@ describe('lsp_incremental_indexer unit tests', () => {
     // fitted into a single batch index.
     assert.ok(bulkSpy.calledOnce);
     assert.strictEqual(bulkSpy.getCall(0).args[0].body.length, 9 * 2);
-    // @ts-ignore
   }).timeout(20000);
 
   it('Cancel LSP index process.', async () => {
@@ -297,7 +293,5 @@ describe('lsp_incremental_indexer unit tests', () => {
     assert.ok(bulkSpy.calledOnce);
     assert.strictEqual(bulkSpy.getCall(0).args[0].body.length, 3 * 2);
     assert.strictEqual(deleteByQuerySpy.callCount, 2);
-    // @ts-ignore
   }).timeout(20000);
-  // @ts-ignore
 }).timeout(20000);

x-pack/plugins/code/server/__tests__/lsp_indexer.ts

@@ -124,23 +124,22 @@ function setupLsServiceSendRequestSpy(): sinon.SinonSpy {
     })
   );
 }
+
 describe('lsp_indexer unit tests', () => {
-  // @ts-ignore
   before(async () => {
     return new Promise(resolve => {
       rimraf(serverOptions.repoPath, resolve);
     });
   });
 
   beforeEach(async function() {
-    // @ts-ignore
     this.timeout(200000);
     return await prepareProject(
       'https://github.com/Microsoft/TypeScript-Node-Starter.git',
       path.join(serverOptions.repoPath, repoUri)
     );
   });
-  // @ts-ignore
+
   after(() => {
     return cleanWorkspace();
   });
@@ -297,7 +296,5 @@ describe('lsp_indexer unit tests', () => {
     // single batch index.
     assert.ok(bulkSpy.calledOnce);
     assert.strictEqual(bulkSpy.getCall(0).args[0].body.length, 33 * 2);
-    // @ts-ignore
   }).timeout(20000);
-  // @ts-ignore
 }).timeout(20000);

x-pack/plugins/code/server/__tests__/lsp_service.ts

@@ -70,7 +70,6 @@ describe('lsp_service tests', () => {
 
   const repoUri = 'github.com/test/test_repo';
 
-  // @ts-ignore
   before(async () => {
     await prepareProject(path.join(serverOptions.repoPath, repoUri));
   });
@@ -140,7 +139,6 @@ describe('lsp_service tests', () => {
     } finally {
       await lspservice.shutdown();
     }
-    // @ts-ignore
   }).timeout(10000);
 
   it('unload a workspace', async () => {
@@ -198,6 +196,5 @@ describe('lsp_service tests', () => {
     } finally {
       await lspservice.shutdown();
     }
-    // @ts-ignore
   }).timeout(10000);
 });

x-pack/plugins/code/server/__tests__/multi_node.ts

@@ -74,12 +74,10 @@ describe('code in multiple nodes', () => {
     nonCodeNode = createRootWithCorePlugins(setting);
     await nonCodeNode.setup();
   }
-  // @ts-ignore
+
   before(startServers);
 
-  // @ts-ignore
   after(async function() {
-    // @ts-ignore
     this.timeout(10000);
     await nonCodeNode.shutdown();
     await servers.stop();
@@ -106,6 +104,5 @@ describe('code in multiple nodes', () => {
     await codeNode.setup();
     await delay(2000);
     await request.get(nonCodeNode, '/api/code/setup').expect(200);
-    // @ts-ignore
   }).timeout(20000);
 });

x-pack/plugins/code/server/__tests__/tsconfig.json

@@ -0,0 +1,17 @@
+{
+  "extends": "../../../../tsconfig.json",
+  "compilerOptions": {
+    // TODO why we have to have this
+    "resolveJsonModule": true,
+    "types": [
+      "mocha",
+      "node"
+    ]
+  },
+  "include": [
+    // TODO why we have to have this
+    "../../../../../src/legacy/server/kbn_server.d.ts",
+    "**/*"
+  ],
+  "exclude": [],
+}

x-pack/plugins/code/server/lsp/install_manager.ts

@@ -114,7 +114,6 @@ export class InstallManager {
     let downloaded = 0;
     return await new Promise<string>((resolve, reject) => {
       res
-        // @ts-ignore
         .body!.pipe(stream)
         .on('error', (error: any) => {
           reject(error);

x-pack/tsconfig.json

@@ -9,7 +9,8 @@
   ],
   "exclude": [
     "test/**/*",
-    "**/typespec_tests.ts"
+    "**/typespec_tests.ts",
+    "plugins/code/**/__tests__/**/*"
   ],
   "compilerOptions": {
     "outDir": ".",